API: Update state delta type, handler#5123
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5123 +/- ##
==========================================
- Coverage 53.45% 53.43% -0.03%
==========================================
Files 432 431 -1
Lines 54501 54364 -137
==========================================
- Hits 29132 29047 -85
+ Misses 23101 23060 -41
+ Partials 2268 2257 -11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
winder
reviewed
Feb 9, 2023
Comment on lines
53
to
56
| func (l *mockLedger) GetStateDeltaForRound(rnd basics.Round) (ledgercore.StateDelta, error) { | ||
| panic("implement me") | ||
| args := l.Called(rnd) | ||
| return args.Get(0).(ledgercore.StateDelta), args.Error(1) | ||
| } |
winder
approved these changes
Feb 9, 2023
shiqizng
reviewed
Feb 9, 2023
| Delta: modelDelta, | ||
| } | ||
| err = enc.Encode(conduitType) | ||
| err = enc.Encode(algodType) |
Contributor
There was a problem hiding this comment.
this file can be removed. it was used to convert ledgercore.StateDelta to model.LedgerStateDelta
shiqizng
approved these changes
Feb 9, 2023
winder
changed the title
This was referenced Mar 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the LedgerStateDelta type to be generic so that we can maintain backwards compatibility w/ the types Indexer is used to.
I wasn't sure exactly what to do with the convert vb binary so I've just updated it to remove the dead code.
Test Plan
Updated handler tests--probably the more useful tests will be in the sdk.