RFC: DevMode Improvements#5003
Closed
winder wants to merge 13 commits into
Closed
Conversation
winder
commented
Jan 11, 2023
winder
commented
Jan 11, 2023
| @@ -17,9 +17,12 @@ | |||
| package main | |||
Contributor
Author
There was a problem hiding this comment.
Ignore this file, these are private network changes from another PR.
winder
commented
Jan 11, 2023
| @@ -19,6 +19,7 @@ package netdeploy | |||
| import ( | |||
Contributor
Author
There was a problem hiding this comment.
Ignore this file, these are private network changes from another PR.
winder
commented
Jan 11, 2023
| @@ -172,6 +172,11 @@ func loadTemplate(templateFile string) (NetworkTemplate, error) { | |||
| } | |||
Contributor
Author
There was a problem hiding this comment.
Ignore this file, these are private network changes from another PR.
winder
commented
Jan 11, 2023
Comment on lines
+189
to
+197
| // TODO: Have a real security model. Some ideas: | ||
| // * devmode now uses a custom consensus.json file which sets this value. | ||
| // * private forks have a one time special block that changes the consensus version. | ||
| // * 'devmode' is like 'future' | ||
| // go ahead and put the "hack" in hackathon. | ||
| for idx, proto := range config.Consensus { | ||
| proto.DevMode = true | ||
| config.Consensus[idx] = proto | ||
| } |
Contributor
Author
There was a problem hiding this comment.
For the hackathon, this is how I set the new variable. Some new policy would be required for setting up a network that sets DevMode to true.
winder
commented
Jan 11, 2023
| @@ -19,6 +19,7 @@ package fixtures | |||
| import ( | |||
Contributor
Author
There was a problem hiding this comment.
Ignore this file, these are private network changes from another PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new dev-mode only consensus option to enable dev-mode specific transaction fields. Implement two features with these fields:
Note: This PR includes changes to simplify private network management
Examples
Test Plan
TODO. So far only manual testing has been done.