Goal: goal network create default templates#4891
Merged
algorandskiy merged 28 commits intoFeb 1, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4891 +/- ##
==========================================
- Coverage 53.48% 53.47% -0.02%
==========================================
Files 429 429
Lines 54041 54051 +10
==========================================
- Hits 28905 28903 -2
- Misses 22890 22902 +12
Partials 2246 2246
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
winder
reviewed
Dec 12, 2022
winder
reviewed
Dec 12, 2022
winder
reviewed
Dec 12, 2022
winder
reviewed
Dec 12, 2022
shiqizng
reviewed
Dec 12, 2022
….com/mciccarello/go-algorand into feature/goal_network_create_defaults
Use reader instead of file path.
….com/mciccarello/go-algorand into feature/goal_network_create_defaults
winder
reviewed
Jan 8, 2023
winder
reviewed
Jan 8, 2023
winder
reviewed
Jan 11, 2023
Co-authored-by: Will Winder <wwinder.unh@gmail.com>
….com/mciccarello/go-algorand into feature/goal_network_create_defaults
winder
reviewed
Jan 13, 2023
Co-authored-by: Will Winder <wwinder.unh@gmail.com>
winder
reviewed
Jan 21, 2023
Will's fix for rewards pool balance e2e test Co-authored-by: Will Winder <wwinder.unh@gmail.com>
….com/mciccarello/go-algorand into feature/goal_network_create_defaults
winder
previously approved these changes
Jan 30, 2023
Contributor
algorandskiy
left a comment
algorandskiy
left a comment
There was a problem hiding this comment.
Please add a test case into test/scripts/test_private_network.sh
algorandskiy
approved these changes
Feb 1, 2023
This was referenced Mar 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4848
Particularly interested in if the values in the default templates are what we want (they come from the example in the developer portal). Also, I used separate templates for dev and regular, and I wonder if that is what we want to do or just have one.