CI: Split paralleltest lint excludes to minimize merge conflicts#5002
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5002 +/- ##
==========================================
- Coverage 53.65% 53.63% -0.02%
==========================================
Files 432 432
Lines 54057 54057
==========================================
- Hits 29005 28996 -9
- Misses 22807 22817 +10
+ Partials 2245 2244 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algochoi
approved these changes
Jan 11, 2023
Contributor
algochoi
left a comment
There was a problem hiding this comment.
I'm not aware of style guides on .golangci configs, but the diff looks functionally the same.
winder
pushed a commit
to winder/go-algorand
that referenced
this pull request
Jan 18, 2023
This was referenced Jan 23, 2023
This was referenced Jan 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits paralleltest lint excludes into multiple entries to minimize merge conflicts. Functionally, makes no change.
Since the existing
pathdefinition is on a single line, it's liable to create merge conflicts when there's concurrent PRs updating paralleltest usage.I attempted to provide the definition as a multiline yml string via
>-, but it didn't work. I found no other workarounds and I'd like to avoid merge conflicts in PRs like #4991, #4992, #4993.