Tests: Fix t.Parallel() errors in gen package#4992
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4992 +/- ##
=======================================
Coverage 53.44% 53.45%
=======================================
Files 431 431
Lines 54364 54364
=======================================
+ Hits 29056 29060 +4
+ Misses 23053 23048 -5
- Partials 2255 2256 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Looks good! I have confirmed locally that the go test command above passes and that all test files within the gen package are discovered correctly (connected to #5046).
I'm a bit confused why the data/bookkeeping package has changes, but since the changes look good I don't see any reason not to include them in this PR.
| } { | ||
| tc := tc | ||
| t.Run(fmt.Sprintf("name=%v", tc.name), func(t *testing.T) { | ||
| t.Parallel() |
There was a problem hiding this comment.
this subtest is not safe to parallelize (GenerateGenesisFiles) and I don't think it is worth trying to push parallelization all the way to this level
There was a problem hiding this comment.
Added a nolint comment to prevent parallelization for this entire test
4 participants
Enables https://github.com/kunwardeep/paralleltest on
genby fixing linter warnings. Incrementally moves the ball towards greater unit test parallelization, which reduces local + CI test durations.I vetted for flakiness by running:
Notes: