Fix catchup stateproof race#4887

Merged

id-ms merged 94 commits into

algorand:feature/stateproofs-recoverabilityfrom

almog-t:fix-catchup-stateproof-race

Dec 27, 2022

Commits on Dec 8, 2022

added empty state proof extractor to ledger
Almog Tal
committed
pivoted to working with notifier
Almog Tal
committed
basic builder notify implementation
Almog Tal
committed
Signer no longer depends on parts of the ledger that can get away from it
Almog Tal
committed
basic recovery works
Almog Tal
committed
now using voters post commit
Almog Tal
committed
syncListener renamed to commitListener, now has its own lock
Almog Tal
committed
added a function to query builder existence
Almog Tal
committed
added and used builder existence checking in OnPrepareCommit
Almog Tal
committed
Some cleanup on OnPrepareCommit
Almog Tal
committed
fixed rename in abastractions
Almog Tal
committed
more missing rename
Almog Tal
committed
added some todos and comments
Almog Tal
committed
refactored fall back for state proof message generation
Almog Tal
committed

Commits on Dec 11, 2022

removed todo from builder
Almog Tal
committed
refactored signer with fallbacks
Almog Tal
committed
added missing error params
Almog Tal
committed
create builder now also persists it
Almog Tal
committed
removed todo
Almog Tal
committed
fixed local signature race
Almog Tal
committed

Commits on Dec 13, 2022

fixed deadlock by moving code to votersTracker
Almog Tal
committed
restored recovery.go
Almog Tal
committed
now calling voter's tracker's prepareCommit, also renamed some logging
Almog Tal
committed
now handling errors from onPrepare
Almog Tal
committed
fixed worker_test
Almog Tal
committed
fixed stateproofmessagegenerator tests
Almog Tal
committed
OnPrepareVoterCommit now returns an error
Almog Tal
committed

Commits on Dec 14, 2022

fixed incorrect votersFetcher usage in tests
Almog Tal
committed
refactored builder's broadcast loop
Almog Tal
committed
fixed ledger voters test
Almog Tal
committed
add ledger_test as todo
Almog Tal
committed

Commits on Dec 15, 2022

made TestLedgerVerifiesOldStateProofs flush blocks clearer
Almog Tal
committed
one more fix to ledger_test
Almog Tal
committed
refactored some other tests in ledger_test
Almog Tal
committed
now synchronizing access to the votersForRound cache
Almog Tal
committed

Commits on Dec 18, 2022

added missing func call
Almog Tal
committed
fixed import order
Almog Tal
committed
now synchronizing acctupdates_test mock ledger access
Almog Tal
committed
added rewrite todos in voters_test
Almog Tal
committed
added handling of uninitialzied state proofs
Almog Tal
committed

Commits on Dec 19, 2022

refactored magic in ledget_test
Almog Tal
committed
rewrote TestVoterTrackerDeleteVotersAfterStateproofConfirmed
Almog Tal
committed
further refactor of common functions in test
Almog Tal
committed
finished rewriting TestLimitVoterTracker
Almog Tal
committed
finished rewriting TestTopNAccountsThatHaveNoMssKeys
Almog Tal
committed
fixed most bugs in TestVotersReloadFromDiskPassRecoveryPeriod
Almog Tal
committed
fixed TestVotersReloadFromDiskPassRecoveryPeriod
Almog Tal
committed
improved usage of primitives in ledger_test
Almog Tal
committed

Commits on Dec 20, 2022

removed redundant deref from interface
Almog Tal
committed
CR: removed useless log message
Almog Tal
committed
fixed double unlock in acctonline
Almog Tal
committed
removed redundant locking in prepare and post commit
Almog Tal
committed
moved registerCommitHandler
Almog Tal
committed
renamed ok to exists in cache query
Almog Tal
committed
CR: added locking on callback registration
Almog Tal
committed
renamed builder creation function
Almog Tal
committed
added round to error
Almog Tal
committed

Commits on Dec 21, 2022

now logging an error if builder lookup failed for any reason other than it not being in the db
Almog Tal
committed
CR: created meetsBroadcastPolicy
Almog Tal
committed
fulfills -> meets
Almog Tal
committed
applied lint demand
Almog Tal
committed
CR: builder no longer returns an error on callback, some renaming
Almog Tal
committed
CR: Comments and additional fixes
Almog Tal
committed
removed old callback usages
Almog Tal
committed
fixed log format
Almog Tal
committed

Commits on Dec 22, 2022

changed error handling in commitListener and usage
Almog Tal
committed
added a ledger test to verify that the commitListener survives reloads
Almog Tal
committed
add sp recovery e2e test
algoidan
committed
added test that verifies that builders are actually created on commit
Almog Tal
committed
added assertion of builder non existence before operation
Almog Tal
committed
remove short maxtxnlife for now
algoidan
committed
restored locking to the way it was before, will working with mockcommit
Almog Tal
committed
Merge branch 'fix-catchup-stateproof-race' of https://github.com/almog-t/go-algorand into fix-catchup-stateproof-race
Almog Tal
committed
some more lock restoration
Almog Tal
committed
restored original lock in stateproofMessageGenerator_test
Almog Tal
committed
implemented and used mockCommit in tests
Almog Tal
committed
added test that makes sure that the signer can use the builder's data when it doesn't have access to the ledger
Almog Tal
committed
add test that verifies that the ledger can still succeed in committing if our callback fails
Almog Tal
committed

Commits on Dec 26, 2022

created and used errVotersNotTracked
Almog Tal
committed
removed redundant warn
Almog Tal
committed
added t to stub
Almog Tal
committed
removed redundant newline, fixed voters fetcher stub
Almog Tal
committed
fixed incorrect error wrap
Almog Tal
committed
get function now returns state proof message by value, to allow builder deletion
Almog Tal
committed
modified some comments in voters
Almog Tal
committed
added a comment regarding ignoring builder persistence failure
Almog Tal
committed
no longer using tracker for version
Almog Tal
committed
completed TestLedgerContinuesOnVotersCallbackFailure
Almog Tal
committed
fixed race in ledger_test
Almog Tal
committed
added comment to signer.go
Almog Tal
committed

Commits on Dec 27, 2022

fixed data race in ledger_test
Almog Tal
committed
removed check for empty voters commitment
Almog Tal
committed
renamed existing test
Almog Tal
committed
added comment on voters policy decision
Almog Tal
committed