Fix catchup stateproof race#4887
Merged
id-ms merged 94 commits intoalgorand:feature/stateproofs-recoverabilityfrom Dec 27, 2022
Merged
Fix catchup stateproof race#4887id-ms merged 94 commits intoalgorand:feature/stateproofs-recoverabilityfrom
id-ms merged 94 commits intoalgorand:feature/stateproofs-recoverabilityfrom
Conversation
added 20 commits
December 8, 2022 13:11
added 6 commits
December 13, 2022 10:41
added 6 commits
December 22, 2022 15:06
…g-t/go-algorand into fix-catchup-stateproof-race
… when it doesn't have access to the ledger
…g if our callback fails
id-ms
reviewed
Dec 25, 2022
id-ms
reviewed
Dec 25, 2022
id-ms
reviewed
Dec 25, 2022
added 16 commits
December 26, 2022 11:41
id-ms
approved these changes
Dec 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the race between stateproof goroutines and the ledger by adding a callback in ledger commit preparation.