Skip to content

metrics: add counters for checkAlreadyCommitted, split "InLedger" counters by reason#4881

Merged
algorandskiy merged 4 commits intoalgorand:masterfrom
cce:test-transaction-group-counters
Dec 8, 2022
Merged

metrics: add counters for checkAlreadyCommitted, split "InLedger" counters by reason#4881
algorandskiy merged 4 commits intoalgorand:masterfrom
cce:test-transaction-group-counters

Conversation

@cce
Copy link
Copy Markdown
Contributor

@cce cce commented Dec 8, 2022

Summary

Following on #4839 this adds metrics for different errors returned by checkAlreadyCommitted, which calls TestTransactionGroup. It also adds information to the LeaseInLedger and TransactionInLedger errors to split separate counters for whether a txn/lease was already seen on-chain, or in the pending block evaluator.

Test Plan

Extended TestTxHandlerRememberReportErrorsWithTxPool to use the new counters.

@cce cce added the Enhancement label Dec 8, 2022
@cce cce changed the title metrics: add counters for checkAlreadyCommitted, split XInLedger counters by reason metrics: add counters for checkAlreadyCommitted, split "InLedger" counters by reason Dec 8, 2022
algorandskiy
algorandskiy previously approved these changes Dec 8, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 8, 2022

Codecov Report

Merging #4881 (aed5587) into master (c0e044b) will decrease coverage by 0.02%.
The diff coverage is 53.33%.

@@            Coverage Diff             @@
##           master    #4881      +/-   ##
==========================================
- Coverage   54.06%   54.03%   -0.03%     
==========================================
  Files         427      427              
  Lines       53474    53519      +45     
==========================================
+ Hits        28909    28920      +11     
- Misses      22299    22329      +30     
- Partials     2266     2270       +4     
Impacted Files Coverage Δ
ledger/internal/cow.go 67.44% <0.00%> (ø)
ledger/ledgercore/error.go 0.00% <0.00%> (ø)
ledger/internal/eval.go 48.56% <18.75%> (-0.32%) ⬇️
data/txHandler.go 62.84% <75.00%> (+2.61%) ⬆️
ledger/txtail.go 78.66% <100.00%> (ø)
ledger/tracker.go 72.15% <0.00%> (-2.96%) ⬇️
network/wsPeer.go 68.97% <0.00%> (-2.87%) ⬇️
catchup/service.go 68.59% <0.00%> (-1.21%) ⬇️
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
cmd/tealdbg/debugger.go 72.69% <0.00%> (-0.81%) ⬇️
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@algorandskiy algorandskiy merged commit 4e58dbd into algorand:master Dec 8, 2022
@cce cce deleted the test-transaction-group-counters branch December 9, 2022 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants