txHandler: metrics for txpool.Remember#4839
Merged
algorandskiy merged 15 commits intoalgorand:masterfrom Dec 8, 2022
Merged
Conversation
00fd927 to
eac33cd
Compare
Codecov Report
@@ Coverage Diff @@
## master #4839 +/- ##
==========================================
+ Coverage 54.03% 54.07% +0.03%
==========================================
Files 426 427 +1
Lines 53409 53463 +54
==========================================
+ Hits 28860 28909 +49
+ Misses 22283 22281 -2
- Partials 2266 2273 +7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cce
reviewed
Nov 30, 2022
cce
reviewed
Nov 30, 2022
cce
reviewed
Nov 30, 2022
cce
reviewed
Nov 30, 2022
cce
reviewed
Nov 30, 2022
818a525 to
c28ce82
Compare
62a846f to
099d154
Compare
brianolson
approved these changes
Dec 8, 2022
Contributor
brianolson
left a comment
There was a problem hiding this comment.
LGTM; some of these new metrics look really useful
cce
approved these changes
Dec 8, 2022
Contributor
|
This makes me want to add the same new err types and counter breakdowns in TestTransactionGroup as well, the empty group value and inconsistent group value stuff will all call be caught first in TestTransactionGroup |
This was referenced Dec 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Translate some
Remembererror codes into counters.Test Plan
Added unit test to ensure all metrics but two that hard to trigger (ErrNoSpace, ErrTxPoolFeeError).