Skip to content

txHandler: metrics for txpool.Remember#4839

Merged
algorandskiy merged 15 commits intoalgorand:masterfrom
algorandskiy:pavel/metrics-remember
Dec 8, 2022
Merged

txHandler: metrics for txpool.Remember#4839
algorandskiy merged 15 commits intoalgorand:masterfrom
algorandskiy:pavel/metrics-remember

Conversation

@algorandskiy
Copy link
Copy Markdown
Contributor

Summary

Translate some Remember error codes into counters.

Test Plan

Added unit test to ensure all metrics but two that hard to trigger (ErrNoSpace, ErrTxPoolFeeError).

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 30, 2022

Codecov Report

Merging #4839 (e4a7da5) into master (b0ee6be) will increase coverage by 0.03%.
The diff coverage is 61.53%.

@@            Coverage Diff             @@
##           master    #4839      +/-   ##
==========================================
+ Coverage   54.03%   54.07%   +0.03%     
==========================================
  Files         426      427       +1     
  Lines       53409    53463      +54     
==========================================
+ Hits        28860    28909      +49     
+ Misses      22283    22281       -2     
- Partials     2266     2273       +7     
Impacted Files Coverage Δ
data/pools/errors.go 0.00% <0.00%> (ø)
data/transactions/transaction.go 43.04% <0.00%> (ø)
ledger/ledgercore/error.go 0.00% <0.00%> (ø)
ledger/internal/eval.go 48.87% <21.42%> (-0.26%) ⬇️
data/pools/transactionPool.go 49.66% <38.88%> (-0.34%) ⬇️
data/transactions/verify/txn.go 73.72% <54.54%> (-0.74%) ⬇️
data/transactions/error.go 50.00% <66.66%> (+16.66%) ⬆️
data/transactions/logic/eval.go 90.16% <83.33%> (+0.01%) ⬆️
data/txHandler.go 60.23% <94.28%> (+11.59%) ⬆️
network/wsPeer.go 67.06% <0.00%> (-1.91%) ⬇️
... and 10 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Comment thread data/pools/errors.go Outdated
Comment thread data/txHandler.go Outdated
Comment thread data/txHandler.go Outdated
Comment thread data/txHandler.go Outdated
Comment thread data/txHandler.go Outdated
@algorandskiy algorandskiy requested a review from cce November 30, 2022 19:18
@algorandskiy algorandskiy force-pushed the pavel/metrics-remember branch from 818a525 to c28ce82 Compare December 7, 2022 20:19
@algorandskiy algorandskiy force-pushed the pavel/metrics-remember branch from 62a846f to 099d154 Compare December 7, 2022 21:07
Copy link
Copy Markdown
Contributor

@brianolson brianolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; some of these new metrics look really useful

@cce
Copy link
Copy Markdown
Contributor

cce commented Dec 8, 2022

This makes me want to add the same new err types and counter breakdowns in TestTransactionGroup as well, the empty group value and inconsistent group value stuff will all call be caught first in TestTransactionGroup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants