Skip to content

prefetcher: preallocate aligned groupTasks in groupsReady #4876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
algorandskiy merged 1 commit into from
Dec 9, 2022
Merged

prefetcher: preallocate aligned groupTasks in groupsReady #4876

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions ledger/internal/prefetcher/prefetcher.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,14 +270,18 @@ func (p *accountPrefetcher) prefetch(ctx context.Context) {
totalBalances := 0
totalResources := 0

groupsReady := make([]groupTask, len(p.txnGroups))
// initialize empty groupTasks for groupsReady
groupsReady := make([]*groupTask, len(p.txnGroups))
for i := range groupsReady {
groupsReady[i] = new(groupTask) // this ensures each allocated groupTask is 64-bit aligned
}

// Add fee sink to the first group
if len(p.txnGroups) > 0 {
// the feeSinkAddr is known to be non-empty
feeSinkPreloader := &preloaderTask{
address: &p.feeSinkAddr,
groupTasks: []*groupTask{&groupsReady[0]},
groupTasks: []*groupTask{groupsReady[0]},
groupTasksIndices: []int{0},
}
groupsReady[0].balancesCount = 1
Expand All @@ -288,7 +292,7 @@ func (p *accountPrefetcher) prefetch(ctx context.Context) {
// iterate over the transaction groups and add all their account addresses to the list
queue := &tasksQueue
for i := range p.txnGroups {
task := &groupsReady[i]
task := groupsReady[i]
for j := range p.txnGroups[i] {
stxn := &p.txnGroups[i][j]
switch stxn.Txn.Type {
Expand Down Expand Up @@ -380,7 +384,7 @@ func (p *accountPrefetcher) prefetch(ctx context.Context) {
groupDoneCh := make(chan groupTaskDone, len(groupsReady))
const dependencyFreeGroup = -int64(^uint64(0)/2) - 1
for grpIdx := range groupsReady {
gr := &groupsReady[grpIdx]
gr := groupsReady[grpIdx]
gr.groupTaskIndex = int64(grpIdx)
gr.incompleteCount = int64(gr.balancesCount + gr.resourcesCount)
gr.balances = allBalances[usedBalances : usedBalances+gr.balancesCount]
Expand Down