prefetcher: preallocate aligned groupTasks in groupsReady#4876
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4876 +/- ##
==========================================
- Coverage 53.31% 52.01% -1.30%
==========================================
Files 423 423
Lines 53852 53853 +1
==========================================
- Hits 28713 28014 -699
- Misses 22854 23521 +667
- Partials 2285 2318 +33
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cce
force-pushed
the
align-prefetcher-groupsReady
branch
from
3ad00a9 to
a1eea0f
Compare
algorandskiy
approved these changes
Dec 9, 2022
This was referenced Dec 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For #4855 this ensures these groupTask{} objects are allocated outside of a slice, to ensure 64-bit alignment for each.
Test Plan
Existing tests should pass.