Skip to content

Tests: Squelch macOS accept incoming network connections notifications #4814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jannotti merged 1 commit into from
Nov 18, 2022
Merged

Tests: Squelch macOS accept incoming network connections notifications #4814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion catchup/fetcher_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ func (b *basicRPCNode) RegisterHandlers(dispatch []network.TaggedMessageHandler)

func (b *basicRPCNode) start() bool {
var err error
b.listener, err = net.Listen("tcp", "")
b.listener, err = net.Listen("tcp", "127.0.0.1:")
if err != nil {
logging.Base().Error("tcp listen", err)
return false
Expand Down
2 changes: 1 addition & 1 deletion rpcs/txService_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ func (b *basicRPCNode) RegisterHandlers(dispatch []network.TaggedMessageHandler)

func (b *basicRPCNode) start() bool {
var err error
b.listener, err = net.Listen("tcp", "")
b.listener, err = net.Listen("tcp", "127.0.0.1:")
if err != nil {
logging.Base().Error("tcp listen", err)
return false
Expand Down
6 changes: 3 additions & 3 deletions util/metrics/counter_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ func TestMetricCounter(t *testing.T) {
}

// create a http listener.
port := test.createListener(":0")
port := test.createListener("127.0.0.1:0")

metricService := MakeMetricService(&ServiceConfig{
NodeExporterListenAddress: fmt.Sprintf("localhost:%d", port),
Expand Down Expand Up @@ -85,7 +85,7 @@ func TestMetricCounterFastInts(t *testing.T) {
}

// create a http listener.
port := test.createListener(":0")
port := test.createListener("127.0.0.1:0")

metricService := MakeMetricService(&ServiceConfig{
NodeExporterListenAddress: fmt.Sprintf("localhost:%d", port),
Expand Down Expand Up @@ -132,7 +132,7 @@ func TestMetricCounterMixed(t *testing.T) {
}

// create a http listener.
port := test.createListener(":0")
port := test.createListener("127.0.0.1:0")

metricService := MakeMetricService(&ServiceConfig{
NodeExporterListenAddress: fmt.Sprintf("localhost:%d", port),
Expand Down
2 changes: 1 addition & 1 deletion util/metrics/gauge_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ func TestMetricGauge(t *testing.T) {
MetricTest: NewMetricTest(),
}
// create a http listener.
port := test.createListener(":0")
port := test.createListener("127.0.0.1:0")

metricService := MakeMetricService(&ServiceConfig{
NodeExporterListenAddress: fmt.Sprintf("localhost:%d", port),
Expand Down