Tests: Squelch macOS accept incoming network connections notifications#4814
Merged
Conversation
michaeldiamant
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4814 +/- ##
==========================================
- Coverage 54.62% 54.25% -0.37%
==========================================
Files 417 417
Lines 53734 53734
==========================================
- Hits 29351 29156 -195
- Misses 21946 22142 +196
+ Partials 2437 2436 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
|
Amazing |
jannotti
approved these changes
Nov 18, 2022
This was referenced Nov 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running unit tests on macOS results in several firewall-related accept/deny prompts asking: Do you want the application X to accept incoming network connections? The PR prevents these pop-ups by applying https://apple.stackexchange.com/a/405967 to affected tests.