go-algorand 2.10.1-beta#2800
Merged
Merged
Conversation
…lgorand#2784) This also unifies a lot of field handling so that the code is less susceptible to copy-paste errors, but it has a ways to go. Hard to both unify the handling of the different fields and use separate types for each field index. Lots and lots of interfaces could do. Or generics in 6 months? For the moment, each field type is a pile of arrays and maps working together. It's unclear what we gain from those separate index types, since we always cast into the type just before using them, as we are getting the indexes from reading a byte in bytecode. New tests will catch this mistake if we make it again.
algojack
requested review from
algobarb,
bricerisingalgorand,
egieseke,
onetechnical and
tsachiherman
Codecov Report
@@ Coverage Diff @@
## rel/beta #2800 +/- ##
============================================
- Coverage 47.14% 47.11% -0.03%
============================================
Files 349 349
Lines 56321 56351 +30
============================================
- Hits 26550 26548 -2
- Misses 26800 26830 +30
- Partials 2971 2973 +2
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Highlights
This is a maintenance release focused around many test improvements and other optimizations.
Changes
app_params_get AppApprovalProgram(Create a quine to testapp_params_get AppApprovalProgram#2682)Balances.PutWithCreatable()#2638)Eval()function for indexer #2662)EncodeSignedTxn()andDecodeSignedTxn()if consensus protocol is unknown. (Return an error inEncodeSignedTxn()andDecodeSignedTxn()if consensus protocol is unknown. #2708)Protocol Upgrade
This release does not contain a protocol upgrade.
Additional Resources