replace the KMD usage in pingpong with direct signing#2653
Conversation
|
Still should have local storage for generated accounts |
|
|
||
| fmt.Printf("adjusting account balance to %d\n", minFund) | ||
| for addr, balance := range accounts { | ||
| for addr, val := range accounts { |
| cfg PpConfig | ||
| accounts map[string]uint64 | ||
| cfg PpConfig | ||
| //accounts map[string]uint64 |
There was a problem hiding this comment.
drop commented out lines.
| return | ||
| } | ||
|
|
||
| psig = accounts[signer].sk.Sign(logic.Program(cfg.Program)) |
There was a problem hiding this comment.
I could be wrong, but I think that you might want to do
progb := logic.Program(cfg.Program)
psig = accounts[signer].sk.Sign(&progb)
tsachiherman
left a comment
tsachiherman
left a comment
There was a problem hiding this comment.
This PR seems to fail for the following test cases:
asset_transfer_small, asset_transfer_large, stateful_teal_small, stateful_teal_medium, stateful_teal_large.
Could you manually test that locally and make sure it generates valid transactions ?
Codecov Report
@@ Coverage Diff @@
## master #2653 +/- ##
==========================================
+ Coverage 47.04% 47.05% +0.01%
==========================================
Files 349 349
Lines 55814 55814
==========================================
+ Hits 26256 26262 +6
+ Misses 26608 26605 -3
+ Partials 2950 2947 -3
Continue to review full report at Codecov.
|
tsachiherman
changed the title
This reverts commit 8835bfd.
4 participants
Summary
Removes signing calls to KMD by creating internal hashmap and signing transactions locally.
Resolves #2644
Test Plan
Tested using performance system.