Revert compile sourcemap#227
Merged
Merged
Conversation
Contributor
|
Adresses #226 |
ahangsu
approved these changes
Aug 23, 2022
1 task
ahangsu
added a commit
that referenced
this pull request
Sep 2, 2022
…ng (#231) * Revert compile sourcemap (#227) * Revert compile sourcemap * Add space * Delete sourcemap2.json * Bugfix: channel v source (#224) * Deprecation of langspec testcases (#225) Co-authored-by: algochoi <86622919+algochoi@users.noreply.github.com> Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts the sourcemap.json file. This is a short term fix to pass builds.
Eventually, we need to remove the
mappingfield in the go-algorand API here: https://github.com/algorand/go-algorand/blob/31037ed403b76f708097b1eb37570d611132ca6e/data/transactions/logic/sourcemap.go#L40There should be no changes to the SDKs since they parse the JSON response directly, but the corresponding test resource in
algorand-sdk-testingshould be changed to remove themappingfield.Here are the changes in the SDK testing repo and the Py SDK repo to confirm that build are passing again:
https://github.com/algorand/algorand-sdk-testing/pull/192/files#diff-0a7ecfb6e41efcb68835b21de89d02950802a01db753ced46b1e1aad303a63deR31
Py SDK: https://app.circleci.com/pipelines/github/algorand/py-algorand-sdk/864/workflows/882405cc-dd70-463a-b188-f59c1670b662/jobs/3890