Bugfix: channel v source#224
Merged
Merged
Conversation
* Initial (empty) commit * Add boxes field for appl calls * Add golden for box storage appl txn encoding test * Change spacing * Update spacing on transaction feature table * Change goldens for box encoding * Add boxes field to app call tests * Fix box values for app calls * Change test branch and change golden from bytes encoding * Change test branch and repo * Add boxes field for app calls * Add some tricky self referenced app ids * Change boxes field in feetest to empty entry * Add encoding to box args * Move boxes field up to lessen pain * Add test for b64 nulls and invalid utf8s * Add test case for empty box names
* Add some path tests for app box by name * Minor wording * Add case for forward slashes
* integration tests for exercising box features * prefix box name with str:
* Update box path tests to take new encoding scheme * Formatting * WIP - test against the CI * Revert back test branch * Escape : character * Change wording around encoded box names * Formatting
* Add path tests for GetApplicationBoxes * Change step name to include this application and add list box name tests * Spacing * Reduce number of redundant steps * Add query to boxes path test * Boxes: Point go-algorand to boxes_response_rework (#210) * Revert back go-algorand testing branch Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>
tzaffi
commented
Aug 23, 2022
tzaffi
commented
Aug 23, 2022
algochoi
reviewed
Aug 23, 2022
Contributor
algochoi
left a comment
algochoi
left a comment
There was a problem hiding this comment.
The changes seem to work properly on my local machine! what is the problem with the compile.feature file?
ahangsu
reviewed
Aug 23, 2022
Contributor
Author
ahangsu
reviewed
Aug 23, 2022
algochoi
approved these changes
Aug 23, 2022
Contributor
algochoi
left a comment
algochoi
left a comment
There was a problem hiding this comment.
Thank you for the fix! Can confirm the builds now work 😄
ahangsu
reviewed
Aug 23, 2022
added 2 commits
August 23, 2022 14:45
ahangsu
approved these changes
Aug 23, 2022
added 2 commits
August 23, 2022 14:48
This was referenced Aug 23, 2022
ahangsu
added a commit
that referenced
this pull request
Sep 2, 2022
…ng (#231) * Revert compile sourcemap (#227) * Revert compile sourcemap * Add space * Delete sourcemap2.json * Bugfix: channel v source (#224) * Deprecation of langspec testcases (#225) Co-authored-by: algochoi <86622919+algochoi@users.noreply.github.com> Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sandbox is always defaulting to
releaseand the generatedconfig.harnessisn't sticking because the verbose flag is provided in the wrong order.Additionally, after refactoring the SDK Sandboxization PR's to no longer overwrite
.env, there is no way to pass through the verbosity, except by overwriting. The PR re-enables passing through by also readingVERBOSE_HARNESSas a flag (either-vor--verbose).For more details regarding "before" and "after" behavior on Circle, see the companion Python SDK PR