Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix clippy & enhance CI/CD #78

Merged
merged 4 commits into from
Jul 8, 2022
Merged

fix clippy & enhance CI/CD #78

merged 4 commits into from
Jul 8, 2022

Commits on Jun 16, 2022

  1. fix clippy::unused_io_amount 

    See related clippy documentation,
but in short some partial reads can occur
in particular with io on the networl.
read_exact/write_all transparently handle such errors.

The fix actually revealed a bug
in 'mp4a' atom parsing, but this is a dangerous change:
Parsing bugs that were transparently ignored
are now failing with error (unattended io eof).
    @ririsoft
    ririsoft committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    f830fd6 View commit details
    Browse the repository at this point in the history

  2. fix trivial clippy errors

    @ririsoft
    ririsoft committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    b988922 View commit details
    Browse the repository at this point in the history

  3. fix clippy error with always 0 value

    @ririsoft
    ririsoft committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    22b1b7b View commit details
    Browse the repository at this point in the history

  4. run ci/cd with clippy and latest rust version

    @ririsoft
    ririsoft committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    54873a6 View commit details
    Browse the repository at this point in the history