fix clippy & enhance CI/CD #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See related clippy documentation, but in short some partial reads can occur in particular with io on the networl. read_exact/write_all transparently handle such errors. The fix actually revealed a bug in 'mp4a' atom parsing, but this is a dangerous change: Parsing bugs that were transparently ignored are now failing with error (unattended io eof).
|
Hey, sorry for the late response, but thank you for the PR! |
jprochazk
pushed a commit
to jprochazk/mp4
that referenced
this pull request
Sep 18, 2024
* fix clippy::unused_io_amount See related clippy documentation, but in short some partial reads can occur in particular with io on the networl. read_exact/write_all transparently handle such errors. The fix actually revealed a bug in 'mp4a' atom parsing, but this is a dangerous change: Parsing bugs that were transparently ignored are now failing with error (unattended io eof). * fix trivial clippy errors * fix clippy error with always 0 value * run ci/cd with clippy and latest rust version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes clippy errors and enhance the CI/CD with clippy checks and running latest rust version.
I would recommend to have a deep look at commit
fix clippy::unused_io_amount: it allowed to fix a bug inmp4aparsing, whereBoxHeader::readerrors were silently ignored and could lead to "overflow read". But now the change could makemp4returns an error in some cases where it did not and could break existing code based on this bad behavior.Up to you to release it as a breaking change release or not.
Last I would recommend to check whether my fix for
fix clippy error with always 0 valueis correct. There was truly a bug, but I am not completely sure my fix is the one expected.Cheers.