Skip to content

Fix AssertionError aleph.vm.orchestrator.views.status_check_fastapi #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Fix AssertionError aleph.vm.orchestrator.views.status_check_fastapi #740

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09f6e84
Fix AssertionError aleph.vm.orchestrator.views.status_check_fastapi
olethanh Jan 15, 2025
6d042fa
Merge branch 'main' into ALEPH-355-assertion-error-aleph-vm-orchestra…
olethanh Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/aleph/vm/orchestrator/status.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,7 @@
"""Check that the VM has IPv4 connectivity."""
try:
result: dict = await get_json_from_vm(session, vm_id, "/ip/4")
assert result["result"] is True
return True
return result["result"]

Check warning on line 101 in src/aleph/vm/orchestrator/status.py

View check run for this annotation

Codecov / codecov/patch

src/aleph/vm/orchestrator/status.py#L101 

Added line #L101 was not covered by tests
except ClientResponseError:
return False

Expand All @@ -108,9 +107,7 @@
"""Check that the VM has IPv6 connectivity."""
try:
result: dict = await get_json_from_vm(session, vm_id, "/ip/6")
assert result["result"] is True
assert "headers" in result
return True
return result["result"]

Check warning on line 110 in src/aleph/vm/orchestrator/status.py

View check run for this annotation

Codecov / codecov/patch

src/aleph/vm/orchestrator/status.py#L110 

Added line #L110 was not covered by tests
except ClientResponseError:
return False

Expand Down
Loading