Skip to content

Conversation

@olethanh
Copy link
Collaborator

Jira Issue: ALEPH-355
Sentry Issue: ALEPH-VM-STAGING-2G

Problem:
Code was asserting that result is always true but the diagnostic vm can return False or True for the ip check, so the whole status_check_fastapi was failing

Solution:
return its result instead of expecting true

Jira Issue: ALEPH-355
Sentry Issue: ALEPH-VM-STAGING-2G

Problem:

The diagnostic vm can return False or True for the ip check, return its result
instead of expecting true

 otherwise the whole status_check_fastapi was failing
@codecov
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 62.92%. Comparing base (76c6897) to head (6d042fa).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/aleph/vm/orchestrator/status.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #740      +/-   ##
==========================================
+ Coverage   62.89%   62.92%   +0.02%     
==========================================
  Files          71       71              
  Lines        6352     6349       -3     
  Branches      519      519              
==========================================
  Hits         3995     3995              
+ Misses       2197     2194       -3     
  Partials      160      160              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olethanh olethanh requested a review from hoh January 16, 2025 12:47
@nesitor nesitor merged commit 38c74fe into main Jan 23, 2025
11 of 22 checks passed
@nesitor nesitor deleted the ALEPH-355-assertion-error-aleph-vm-orchestrator-views-status-check-fastapi branch January 23, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants