- 
        Couldn't load subscription status. 
- Fork 18
          Fix: Binary sevctl was absent from debian packages
          #629
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Codecov ReportAll modified and coverable lines are covered by tests ✅ 
 Additional details and impacted files@@           Coverage Diff           @@
##             main     #629   +/-   ##
=======================================
  Coverage   58.73%   58.73%           
=======================================
  Files          62       62           
  Lines        5481     5482    +1     
  Branches      608      608           
=======================================
+ Hits         3219     3220    +1     
  Misses       2122     2122           
  Partials      140      140           ☔ View full report in Codecov by Sentry. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but shouldn't we do some kind of caching for this not not agravate the CI time further
| Test are failing  | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we enable git submodules on the repo, maybe we need to also add it on the docs.
Solution: Build `sevctl` using an upstream version of Rust (the version in Debian is not supported), and bundle it in the Debian packages. Add a setting in aleph-vm with the path of the bundled binary.
Solution: Build
sevctlusing an upstream version of Rust (the version in Debian is not supported), and bundle it in the Debian packages.Add a setting in aleph-vm with the path of the bundled binary.