Implement get platform certificates endpoint #619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ficates generated by sevctl. Solution: Set that directory field on settings class and ensure to create the folder on initialization step.
…atform certificates to start the VM key exchange. Solution: Create that endpoint and return the platform certificates generated by the `sevctl` command.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #619 +/- ##
==========================================
+ Coverage 57.95% 58.32% +0.37%
==========================================
Files 60 61 +1
Lines 5406 5464 +58
Branches 601 607 +6
==========================================
+ Hits 3133 3187 +54
- Misses 2133 2137 +4
Partials 140 140 ☔ View full report in Codecov by Sentry. |
hoh
reviewed
Jun 3, 2024
Base automatically changed from
andres-feature-add_confidential_directory_setting
to
main
June 5, 2024 08:04
hoh
reviewed
Jun 5, 2024
…certificates # Conflicts: # src/aleph/vm/conf.py
hoh
reviewed
Jun 5, 2024
hoh
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: There isn't an endpoint to be able to get the confidential platform certificates to start the VM key exchange.
Solution: Create that endpoint and return the platform certificates generated by the
sevctlcommand.