Repository navigation
✨ Feature: Enhance What's New with Commit Links and Summary - #93
Conversation
- Implement 7-character commit hash parsing with links to GitHub. - Add "Recent Highlights" summary box prioritizing features and fixes. - Add unit tests for release normalization and commit parsing. - Refine styling for commit tags and summary layout. Co-authored-by: alehar9320 <5390430+alehar9320@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| 🔵 In progress View logs |
me | 1b0dc34 | Commit Preview URL Branch Preview URL |
Apr 11 2026, 07:38 AM |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughParses release markdown into structured ReleaseItem objects (message, optional 7-char commit hash and URL), updates tests to expect objects, and adds client-side "Recent Highlights" extraction plus commit-hash link rendering and related styling on the whats-new page. Changes
Sequence Diagram(s)mermaid Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/__tests__/github-releases.test.ts (1)
72-94: Add a regression case for headings plus*bullets.These tests only prove the
- ...happy path. Please add one case like## What's Changed\n* 8acc628 ...\n* Plain messageso the suite catches the exact markdown shape/whats-newconsumes from GitHub releases.🧪 Suggested test addition
+ it('ignores headings and parses GitHub-style bullets', () => { + const body = "## What's Changed\n* 8acc628 ✍️ Scribe: Strategic Copy Optimization\n* Plain message"; + + expect(splitReleaseBody(body)).toEqual([ + { + hash: '8acc628', + message: '✍️ Scribe: Strategic Copy Optimization', + url: 'https://github.com/alehar9320/astro-cloudflare-personal-website/commit/8acc628', + }, + { + message: 'Plain message', + }, + ]); + });Based on learnings, GitHub releases and tags are the canonical source for versioning and changelog history.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/__tests__/github-releases.test.ts` around lines 72 - 94, Add a regression test that covers headings plus asterisk bullets by adding an it() case that calls splitReleaseBody with a body like "## What's Changed\n* 8acc628 ✍️ Scribe: Strategic Copy Optimization\n* Plain message" and assert it returns the same parsed items as the existing dash-bullet test (first item with hash '8acc628', message '✍️ Scribe: Strategic Copy Optimization', url built for that hash, and second item with message 'Plain message'); ensure the test references the splitReleaseBody helper so the parser handles '*' bullets and headings the same as '-' bullets.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/utils/github-releases.ts`:
- Around line 89-114: The parser treats any non-empty line as a ReleaseItem and
only strips "- ", causing headings like "## ..." or other list markers ("*",
"+") to become changelog entries and preventing commit-hash parsing; update
splitReleaseBody and parseReleaseItem so splitReleaseBody first ignores heading
lines starting with "#" and removes common markdown list markers (e.g., "-",
"*", "+") from the start of each line before trimming, then call
parseReleaseItem; inside parseReleaseItem ensure you normalize the incoming line
(with markers removed) before running the hash regex so lines like "* 8acc628
..." are parsed into a ReleaseItem with hash/url and heading lines are skipped
entirely (no ReleaseItem returned).
---
Nitpick comments:
In `@src/__tests__/github-releases.test.ts`:
- Around line 72-94: Add a regression test that covers headings plus asterisk
bullets by adding an it() case that calls splitReleaseBody with a body like "##
What's Changed\n* 8acc628 ✍️ Scribe: Strategic Copy Optimization\n* Plain
message" and assert it returns the same parsed items as the existing dash-bullet
test (first item with hash '8acc628', message '✍️ Scribe: Strategic Copy
Optimization', url built for that hash, and second item with message 'Plain
message'); ensure the test references the splitReleaseBody helper so the parser
handles '*' bullets and headings the same as '-' bullets.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: bcbfbaa3-96fc-422d-92ac-3557acc1607f
📒 Files selected for processing (3)
src/__tests__/github-releases.test.tssrc/pages/whats-new.astrosrc/utils/github-releases.ts
Bundle ReportBundle size has no change ✅ Affected Assets, Files, and Routes:view changes for bundle: molecular-mars-esmAssets Changed:
|
|
@jules Verify each finding against the current code and only fix it if needed. In |
- Add prioritized "Recent Highlights" summary box at the top of the page. - Improve changelog parsing to support multiple list markers (-, *, +) and ignore headers. - Automatically link 7-character commit hashes to the GitHub repository. - Ensure consistent glassmorphic styling in light and dark modes. - Add comprehensive unit tests for new parsing logic. Co-authored-by: alehar9320 <5390430+alehar9320@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/__tests__/github-releases.test.ts`:
- Around line 72-80: The test for splitReleaseBody is asserting that a non-list
"Plain line" becomes a changelog item, which contradicts the intended “only
valid list items” behavior; update the test in the it block that uses
splitReleaseBody to remove the { message: 'Plain line' } expectation (i.e., only
assert items for '- feat: one', '* fix: two', '+ docs: three') and/or add a
separate test that explicitly asserts non-list lines are ignored; reference
splitReleaseBody in the test to locate and change the expected output
accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: df52511c-5479-4a0e-96cf-277740b39ebc
📒 Files selected for processing (2)
src/__tests__/github-releases.test.tssrc/utils/github-releases.ts
🚧 Files skipped from review as they are similar to previous changes (1)
- src/utils/github-releases.ts
|
@jules Verify each finding against the current code and only fix it if needed. In |
I have updated |
- Update `splitReleaseBody` to only accept lines starting with -, *, or +. - Update unit tests to verify non-list lines and headers are ignored. - Address PR feedback regarding "Plain line" behavior. Co-authored-by: alehar9320 <5390430+alehar9320@users.noreply.github.com>
This PR enhances the 'What's New' page to provide better visibility into recent development activity.
Key changes:
src/utils/github-releases.test.tsensure stable parsing across various release body formats.PR created automatically by Jules for task 14336017390907814763 started by @alehar9320
Summary by CodeRabbit
New Features
Tests
Style