Repository navigation
🛡️ Sentinel: Safe JSON-LD Schema Serialization - #1599
Conversation
Created safeJsonLd helper to replace '<' with '\u003c' during JSON-LD schema serialization across Astro pages. This prevents closing script tag breakouts (</script>) and XSS vulnerabilities in inline JSON-LD script elements. Co-authored-by: alehar9320 <5390430+alehar9320@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
me | 444f6f0 | Commit Preview URL Branch Preview URL |
Oct 07 2026, 01:52 AM |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (9)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change adds ChangesJSON-LD serialization
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to All six JSON-LD pages use the escaping helper, and no actionable merge-blocking risk remains in the reviewed changes. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Bundle ReportBundle size has no change ✅ Affected Assets, Files, and Routes:view changes for bundle: molecular-mars-esmAssets Changed:
|
|
Owner review (Eng PASS) on tip Value: yes. Small, scoped hardening: Soft nit (parked, not blocking): the Process: Converting to DRAFT as alehar9320-bot (auto-merge had fired with no Dual). HOLD for Johan + Vera Dual CLOSE of this exact tip, then FINAL READY and squash. @jules please do not push further changes or restack unless asked; this tip is the one under review. |
|
Daily PR queue sweep (Nick, 2026-10-07 ~08:05 CEST). Live/prod SENTRY MATCH Owner Eng PASS on tip Johan + Vera: Dual OWN of THIS tip |
|
Johan (Lead UX) Dual OWN: PASS on tip I checked the Workers preview for this commit against prod (
There's no brand or visitor risk. Keep it in DRAFT until Vera's Dual OWN, then Dual CLOSE, FINAL READY and Bob squash, as Nick set out. @jules please don't push again. |
|
Daily PR queue sweep (Nick, 2026-10-08 ~08:00 CEST). Live/prod SENTRY MATCH Johan Dual OWN PASS on tip Vera: Dual OWN of THIS tip |
|
Vera (Manual Verifier) Dual OWN: PASS on tip Diff: new Preview
Johan PASSed on the same tip (comment 6032703874), so this is Dual CLOSE BOTH OWN on |
|
Squashed by Bob (bot) at 08:19 CEST onto main as Dual CLOSE on tip LIVE Dual pending (Johan + Vera, once prod SENTRY matches the squash). Overlay |
|
LIVE Dual: PASS on prod |
Severity: Medium
Impact: Eliminates potential HTML/script breakout vectors (XSS) in inline JSON-LD
<script type="application/ld+json">elements across all site pages by replacing<with\u003cin serialized schema strings.Changes:
src/utils/safe-json-ld.tsandsrc/utils/safe-json-ld.test.tsJSON.stringify(schema)withsafeJsonLd(schema)inindex.astro,work.astro,work/[...slug].astro,roadmap.astro,whats-new.astro, andbiography.astro.Jules/sentinel.mdPR created automatically by Jules for task 11881948995792762004 started by @alehar9320
Summary by CodeRabbit