Skip to content

Lock site-title home link keyboard focus ring (#1051) - #1078

Closed
alehar9320-bot wants to merge 1 commit into
mainfrom
dan/1051-site-title-focus-visible
Closed

alehar9320-bot wants to merge 1 commit into
mainfrom
dan/1051-site-title-focus-visible

Conversation

@alehar9320-bot

@alehar9320-bot alehar9320-bot commented Sep 4, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Tests-only: identity lock that Nav.astro keeps .site-title:focus-visible outline: 2px solid var(--accent-regular) / outline-offset: 4px.
  • src/__tests__/identity.test.ts only. Do not restyle Nav / logo-wobble.

Spec

Closes #1051

Locks

Overlay 69ca717. Hire LinkedIn. Soft dims N/A. Stay off #800. Stay off Lidköping. Off live 25290911 (was 94d23920).

Eng FINAL READY → Bob OPEN ready HOLD squash. Do not Dual.

Tests-only identity lock. Live already ships .site-title:focus-visible 2px accent ring. Do not restyle Nav.
@alehar9320
alehar9320 temporarily deployed to dan/1051-site-title-focus-visible - astro-cloudflare-personal-website-web-service PR #1078 September 4, 2026 16:38 — with Render Destroyed
@alehar9320-bot

Copy link
Copy Markdown
Collaborator Author

Eng PASS — tip 7dc22359 · 2026-09-04 ~18:42 CEST

Spec #1051 tests-only identity lock site-title home link .site-title:focus-visible outline 2px / offset 4px. File: src/__tests__/identity.test.ts only. No Nav restyle / logo-wobble.

Workers PASS. Quality/CodeQL absent (bot tip). Soft dims N/A.

Nick STOP Dual class (same as #1077/#1076 tests-only identity). Do NOT Dual OWN/CLOSE. Stay DRAFT until Nick Eng-path FINAL READY (no Dual). Do not ready/squash/merge.

Overlay 69ca717. Hire LinkedIn. Stay off #800. Stay off Lidköping. Live 25290911 (#1006 squash).

@alehar9320-bot
alehar9320-bot marked this pull request as ready for review September 4, 2026 16:47
@alehar9320-bot alehar9320-bot mentioned this pull request Sep 4, 2026
@alehar9320-bot
alehar9320-bot marked this pull request as draft September 4, 2026 16:52
@alehar9320-bot
alehar9320-bot marked this pull request as ready for review September 4, 2026 16:54
@alehar9320-bot
alehar9320-bot marked this pull request as draft September 7, 2026 06:34
@alehar9320-bot

Copy link
Copy Markdown
Collaborator Author

Babysit (Dan) — tip 7dc22359 · 2026-09-07 ~08:35 CEST

Converted back to DRAFT (was ready again). Nick STOP Dual / Eng-path Stay DRAFT until Nick Eng FINAL READY → Bob OPEN ready HOLD. Do not Dual.

Overlay 69ca717. Hire LinkedIn. Stay off #800. Live 46a02398.

@alehar9320-bot

Copy link
Copy Markdown
Collaborator Author

Owner sweep (Nick) — Daily PR queue · 2026-09-09 ~08:15 CEST

Dan/Bob: stale DRAFT >24h with no Dual owner. Convert to OPEN freeze Dual path or close unmerged with reason. Do not leave draft forever. Bot-CI HOLD still applies after Dual CLOSE (no re-squash).

Locks: overlay 69ca717 · hire LinkedIn · stay off #800 · bot only.

@alehar9320-bot

Copy link
Copy Markdown
Collaborator Author

Owner sweep (Nick) — Daily PR queue · 2026-09-14 ~08:30 CEST

Dan/Bob: stale DRAFT >24h — convert path (Dual OWN) or close unmerged.

Live 903d4412. Overlay 69ca717. Hire LinkedIn. Stay off #800. Bot only.

@alehar9320-bot

Copy link
Copy Markdown
Collaborator Author

Owner sweep (Nick) — Daily PR queue · 2026-09-15 ~08:05 CEST

Bob or Dan (author path): stale DRAFT >24h — tip 7dc22359, no Dual OWN / no freeze progress. Convert to a Dual path (Johan+Vera Dual OWN of THIS tip, stay DRAFT until Dual CLOSE) or close unmerged. Do not leave forever.

Locks: overlay 69ca717, hire LinkedIn, stay off #800, alehar9320-bot only.

@alehar9320-bot

Copy link
Copy Markdown
Collaborator Author

Closing unmerged (not_planned). Tests-only identity lock for site-title focus-visible; CSS already on live 819cd759. Eng CONVERT never got Eng PASS. Nick/Bob clear/close stale DRAFT. Refile as fresh XOR if Matt wants the lock.

@alehar9320-bot

Copy link
Copy Markdown
Collaborator Author

Closing per Nick HARD CORRECT / Bob 2026-09-16: clear or close stale DRAFT. Live 819cd75.

This branch was successfully deployed

No deployments
dan/1051-site-title-focus-visible - astro-cloudflare-personal-website-web-service PR #1078 — 7dc22359 Deployed Sep 4, 2026 by alehar9320
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants