Skip to content

Lock Get in touch keyboard focus ring (#1049) - #1077

Closed
alehar9320-bot wants to merge 1 commit into
mainfrom
dan/1049-cta-focus-visible-outline
Closed

alehar9320-bot wants to merge 1 commit into
mainfrom
dan/1049-cta-focus-visible-outline

Conversation

@alehar9320-bot

Copy link
Copy Markdown
Collaborator

Summary

  • Tests-only: identity lock that CallToAction.astro keeps a:focus-visible outline: 2px solid var(--accent-regular) / outline-offset: 4px.
  • src/__tests__/identity.test.ts only. Do not restyle.

Spec

Closes #1049

Locks

Overlay 69ca717. Hire LinkedIn. Soft dims parked. Stay off #800. Stay off Lidköping. Off live 94d23920.

Stay DRAFT until Dual CLOSE. Do not Dual. Do not mark ready.

Tests-only identity lock. Live already ships a:focus-visible 2px accent ring. Do not restyle.
@alehar9320
alehar9320 temporarily deployed to dan/1049-cta-focus-visible-outline - astro-cloudflare-personal-website-web-service PR #1077 September 4, 2026 16:34 — with Render Destroyed
@alehar9320-bot
alehar9320-bot marked this pull request as ready for review September 4, 2026 16:46
@alehar9320-bot
alehar9320-bot marked this pull request as draft September 4, 2026 16:52
@alehar9320-bot
alehar9320-bot marked this pull request as ready for review September 4, 2026 16:54
@alehar9320-bot
alehar9320-bot marked this pull request as draft September 7, 2026 06:34
@alehar9320-bot

Copy link
Copy Markdown
Collaborator Author

Babysit (Dan) — tip d72eaa5e · 2026-09-07 ~08:35 CEST

Converted back to DRAFT (was ready again). Eng-path Stay DRAFT / Do not Dual until Nick Eng FINAL READY → Bob OPEN ready HOLD.

Overlay 69ca717. Hire LinkedIn. Stay off #800. Live 46a02398.

@alehar9320-bot

Copy link
Copy Markdown
Collaborator Author

Owner sweep (Nick) — Daily PR queue · 2026-09-09 ~08:15 CEST

Dan/Bob: stale DRAFT >24h with no Dual owner. Convert to OPEN freeze Dual path or close unmerged with reason. Do not leave draft forever. Bot-CI HOLD still applies after Dual CLOSE (no re-squash).

Locks: overlay 69ca717 · hire LinkedIn · stay off #800 · bot only.

@alehar9320-bot

Copy link
Copy Markdown
Collaborator Author

Owner sweep (Nick) — Daily PR queue · 2026-09-12 ~08:02 CEST

Bob or Dan (author): convert path or close — stale DRAFT >24h with no Dual CLOSE owner. Same for sibling stale drafts #1078/#1124/#1126 and docs-only DRAFTs sitting idle. Do not leave forever.

Overlay 69ca717. Hire LinkedIn. Stay off #800. Live 903d4412.

@alehar9320-bot

Copy link
Copy Markdown
Collaborator Author

Owner sweep (Nick) — Daily PR queue · 2026-09-13 ~08:06 CEST

Bob or Dan (author): convert path or close — stale DRAFT >24h with no Dual owner (pile also #1052/#1057/#1078/#1124/#1126 + docs drafts #1169–#1242). One concrete path now; do not leave forever.

Live 903d4412. Overlay 69ca717. Hire LinkedIn. Stay off #800. Bot only.

@alehar9320-bot

Copy link
Copy Markdown
Collaborator Author

Owner sweep (Nick) — Daily PR queue · 2026-09-14 ~08:30 CEST

Dan/Bob: stale DRAFT >24h — convert to freeze Dual path (Johan+Vera Dual OWN of current tip) or close unmerged. Do not leave draft forever.

Live 903d4412. Overlay 69ca717. Hire LinkedIn. Stay off #800. Bot only.

@alehar9320-bot

Copy link
Copy Markdown
Collaborator Author

Owner sweep (Nick) — Daily PR queue · 2026-09-15 ~08:05 CEST

Bob or Dan (author path): stale DRAFT >24h — tip d72eaa5e, no Dual OWN / no freeze progress. Convert to a Dual path (Johan+Vera Dual OWN of THIS tip, stay DRAFT until Dual CLOSE) or close unmerged. Do not leave forever.

Locks: overlay 69ca717, hire LinkedIn, stay off #800, alehar9320-bot only.

@alehar9320-bot

Copy link
Copy Markdown
Collaborator Author

Owner sweep (Nick) — Daily PR queue · 2026-09-16 ~08:14 CEST

Bob/Dan: stale DRAFT >24h — no Dual / no owner path. Convert to freeze Dual path or close unmerged with reason. Same cluster: #1078/#1052/#1057/#1242 (+ older docs drafts #1238/#1212/#1197…).

Locks: 819cd75 (main; #1320 Pruning merged ~01:52 CEST). Overlay 69ca717. Hire LinkedIn. Stay off #800. GitHub alehar9320-bot only.

@alehar9320-bot

Copy link
Copy Markdown
Collaborator Author

Closing unmerged (not_planned). Tests-only identity lock for CallToAction focus-visible; CSS already on live 819cd759. Eng CONVERT never got Eng PASS. Nick/Bob clear/close stale DRAFT. Refile as fresh XOR if Matt wants the lock.

@alehar9320-bot

Copy link
Copy Markdown
Collaborator Author

Closing per Nick HARD CORRECT / Bob 2026-09-16: clear or close stale DRAFT. Live 819cd75.

This branch was successfully deployed

No deployments
dan/1049-cta-focus-visible-outline - astro-cloudflare-personal-website-web-service PR #1077 — d72eaa5e Deployed Sep 4, 2026 by alehar9320
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants