Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK option and logic to drop assist bases #3983

Merged
merged 5 commits into from
Aug 9, 2023
Merged

SDK option and logic to drop assist bases #3983

merged 5 commits into from
Aug 9, 2023

Commits on Aug 7, 2023

  1. Add and wire up options to drop assist bases 

    Right now doesn't change functionality but will be passed through the
stack.
    @ashmrtn
    ashmrtn committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    0841b6f View commit details
    Browse the repository at this point in the history

  2. Drop assist bases if requested 

    Add logic to drop assist bases if asked to and add tests.
    @ashmrtn
    ashmrtn committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    a6cf025 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Minor updates from review 

    Mostly naming and nits.
    @ashmrtn
    ashmrtn committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    7e4efa2 View commit details
    Browse the repository at this point in the history

  2. Fix unit tests 

    Just swap value of input for dropping assist bases.
    @ashmrtn
    ashmrtn committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    891949e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into 2360-disable-assist-incremental

    @aviator-app
    aviator-app[bot] authored Aug 9, 2023
    Configuration menu
    Copy the full SHA
    2aba25e View commit details
    Browse the repository at this point in the history