SDK option and logic to drop assist bases #3983
Conversation
Right now doesn't change functionality but will be passed through the stack.
Add logic to drop assist bases if asked to and add tests.
Current Aviator status
This PR was merged using Aviator. |
| // TODO(ashmrtn): This should probably just return a collection that deletes | ||
| // the entire subtree instead of returning an additional bool. That way base | ||
| // selection is controlled completely by flags and merging is controlled | ||
| // completely by collections. |
There was a problem hiding this comment.
could this cause issues if the backup only partially processes? ie: deletes the subtree, but doesn't complete the rest of the backup?
There was a problem hiding this comment.
no, it should be safe due to how we select bases and persist data. The "deletion" happens during hierarchy merging so it's really just excluding directories from the base when building the in-memory state
If corso crashes partway through the item data backup with the "deleted" state in-memory then we won't select that as a base with the new corso extension base selection logic (it won't have a details snapshot)
If corso hits some error persisting item data while making the snapshot but does still persist the details then the base will be eligible as an assist base on the next backup. That's safe though because the assist base contains all the details we'll need and the original merge base still has all the undeleted items
Mostly naming and nits.
Just swap value of input for dropping assist bases.
|
Kudos, SonarCloud Quality Gate passed!
|
Add a way for SDK users to drop
kopia-assisted incremental bases
thus forcing item data redownload
if the item wasn't sourced from
a merge base
Does this PR need a docs update or release note?
Type of change
Issue(s)
Test Plan