Skip to content

style: apply pre-commit formatting#64

Merged
alandtse merged 1 commit into
devfrom
style/precommit-formatting
May 30, 2026
Merged

style: apply pre-commit formatting#64
alandtse merged 1 commit into
devfrom
style/precommit-formatting

Conversation

@alandtse
Copy link
Copy Markdown
Owner

Summary

Isolates the repo-wide formatting drift that pre-commit.ci auto-applies to every PR into its own style:-only change, so feature PRs stay reviewable (their diffs show logic, not formatter noise).

These are the exact normalizations pre-commit.ci produced (clang-format include ordering, brace placement, preprocessor/whitespace, ternary wrapping) across files that had drifted from the hooks in dev — no logic changes:

  • package/Shaders/{Lighting,ISTemporalAA}.hlsl, features/.../WaterCaustics.hlsli
  • src/Features/{HDRDisplay,LightLimitFix}.cpp, src/Hooks.cpp, src/ShaderCache.h, src/Utils/RestartSettings.h
  • src/WeatherEditor/Weather/*.cpp

Merge first

Land this before the in-flight feature PRs (#62 shader recompile observability, #63 cluster Tracy zones); once it's on dev and those are rebased, their diffs drop the formatter churn and show only their actual changes.

🤖 Generated with Claude Code

Automated formatting by clang-format, prettier, and other hooks.
See https://pre-commit.ci for details.
Copilot AI review requested due to automatic review settings May 30, 2026 19:08
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 30, 2026

Warning

Review limit reached

@alandtse, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 40 minutes. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9bbe2131-cb98-4d7b-8b7a-c66a51f9ee6d

📥 Commits

Reviewing files that changed from the base of the PR and between fcfaab0 and 218c3c8.

📒 Files selected for processing (12)
  • features/Water Effects/Shaders/WaterEffects/WaterCaustics.hlsli
  • package/Shaders/ISTemporalAA.hlsl
  • package/Shaders/Lighting.hlsl
  • src/Features/HDRDisplay.cpp
  • src/Features/LightLimitFix.cpp
  • src/Hooks.cpp
  • src/ShaderCache.h
  • src/Utils/RestartSettings.h
  • src/WeatherEditor/Weather/CellLightingWidget.cpp
  • src/WeatherEditor/Weather/LightingTemplateWidget.cpp
  • src/WeatherEditor/Weather/PrecipitationWidget.cpp
  • src/WeatherEditor/Weather/WeatherWidget.cpp
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch style/precommit-formatting

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR isolates repo formatting drift by applying the exact code-style normalizations produced by pre-commit.ci (e.g., clang-format reflow, brace placement, whitespace, include ordering, and HLSL directive/formatting), so subsequent feature PRs won’t be dominated by formatter churn.

Changes:

  • Normalized C++ formatting in Weather Editor widgets and a few core headers/sources (brace placement, indentation, wrapping).
  • Normalized shader formatting in packaged and feature shaders (preprocessor indentation/spacing, alignment/wrapping).
  • Applied minor include ordering / whitespace cleanups consistent with formatter output.

Reviewed changes

Copilot reviewed 6 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/WeatherEditor/Weather/WeatherWidget.cpp Formatter-only reflow (if-block brace/indent style, wrapping).
src/WeatherEditor/Weather/PrecipitationWidget.cpp Formatter-only indentation/wrapping normalization in UI lambdas.
src/WeatherEditor/Weather/LightingTemplateWidget.cpp Formatter-only re-indentation of initializer lists.
src/WeatherEditor/Weather/CellLightingWidget.cpp Formatter-only brace placement/indent normalization.
src/Utils/RestartSettings.h Formatter-only macro spacing/whitespace normalization.
src/ShaderCache.h Formatter-only whitespace/comment alignment change.
src/Hooks.cpp Formatter-only brace placement change in __except block.
src/Features/LightLimitFix.cpp Formatter-only include reorder / brace placement / trailing whitespace cleanup.
src/Features/HDRDisplay.cpp Formatter-only wrapping/indentation in ternary/conditionals.
package/Shaders/Lighting.hlsl Formatter-only HLSL preprocessor directive indentation/spacing.
package/Shaders/ISTemporalAA.hlsl Formatter-only spacing/alignment and preprocessor directive formatting.
features/Water Effects/Shaders/WaterEffects/WaterCaustics.hlsli Formatter-only ternary wrapping normalization.

@alandtse alandtse merged commit 9e0bd44 into dev May 30, 2026
20 checks passed
@alandtse alandtse deleted the style/precommit-formatting branch May 30, 2026 19:18
@github-actions
Copy link
Copy Markdown

No actionable suggestions for changed features.

@github-actions
Copy link
Copy Markdown

✅ A pre-release build is available for this PR:
Download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants