chore(llf): add Tracy GPU zones for cluster build/cull#63
Conversation
|
Warning Review limit reached
More reviews will be available in 39 minutes and 15 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR adds finer-grained Tracy GPU profiling for LightLimitFix’s clustered lighting compute work, and includes several formatting-only cleanups in WeatherEditor widgets and a few utility/core headers.
Changes:
- Add dedicated
TracyD3D11Zonemarkers to separate LightLimitFix cluster build vs cluster cull GPU timing. - Apply clang-format/whitespace refactors across multiple WeatherEditor widget files (brace expansion, wrapping, alignment).
- Minor formatting adjustments in small headers/source (macro spacing, comment alignment, brace style).
Reviewed changes
Copilot reviewed 6 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/WeatherEditor/Weather/WeatherWidget.cpp | Formatting-only refactors around inheritance UI, tooltips, switch formatting, and alignment. |
| src/WeatherEditor/Weather/PrecipitationWidget.cpp | Formatting-only indentation/alignment changes within UI lambdas. |
| src/WeatherEditor/Weather/LightingTemplateWidget.cpp | Formatting-only alignment changes in search entries initializer. |
| src/WeatherEditor/Weather/CellLightingWidget.cpp | Formatting-only brace expansion and alignment changes in UI/search entry lists. |
| src/Utils/RestartSettings.h | Macro formatting tweak (brace spacing) and trailing whitespace cleanup. |
| src/ShaderCache.h | Comment spacing normalization. |
| src/Hooks.cpp | Brace-style normalization for an __except block. |
| const bool isInherited = drawInheritCheckbox(inheritKey, recordRefs[i], parentRefs[i]); | ||
| ImGui::Text("%s:", label.c_str()); | ||
| ImGui::SameLine(todLabelOffset); | ||
| if (isInherited) PushInheritedStyle(); | ||
| if (isInherited) | ||
| PushInheritedStyle(); | ||
| if (WeatherUtils::DrawFormPickerCached(pickerId, recordRefs[i], widgets, false, true, pickerWidth)) { | ||
| pendingReinit = true; | ||
| if (isInherited) settings.inheritFlags[inheritKey] = false; | ||
| if (isInherited) | ||
| settings.inheritFlags[inheritKey] = false; | ||
| } | ||
| if (isInherited) { | ||
| Util::AddTooltip("Inherited from parent weather"); | ||
| PopInheritedStyle(); | ||
| } | ||
| if (isInherited) { Util::AddTooltip("Inherited from parent weather"); PopInheritedStyle(); } | ||
| drawOpenButton(recordRefs[i], widgets, std::format("Open##{}", i), openTooltip); |
|
No actionable suggestions for changed features. |
|
✅ A pre-release build is available for this PR: |
Isolated per-dispatch GPU timing for the LightLimitFix cluster passes, scoped via TracyD3D11Zone (no-op without TRACY_ENABLE). The existing 'LightLimitFix Prepass' zone lumps both dispatches; these split them so the cull pass can be measured on its own. The include reorder, __except brace, and trailing-newline changes are the pre-commit clang-format/whitespace hooks normalizing pre-existing formatting drift in the file, not part of the instrumentation change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
alandtse
force-pushed
the
feat/llf-cluster-tracy-zones
branch
from
825eab5 to
c89a6d6
Compare
Summary
Adds dedicated
TracyD3D11ZoneGPU markers around the two LightLimitFix cluster-pass dispatches inUpdateStructure—LightLimitFix Cluster BuildandLightLimitFix Cluster Cull. The existingLightLimitFix Prepasszone lumps both dispatches (plus light collection) together; splitting them lets the cull pass be measured in isolation. (Profiling showed the cull is ~92% of the cluster-pass cost — and ~0.8% of frame, vs ~69% for shadow rendering.) No-op withoutTRACY_ENABLE.Notes
The include reorder /
__exceptbrace / trailing-newline hunks are the pre-commit clang-format + whitespace hooks normalizing pre-existing formatting drift inLightLimitFix.cpp— not part of the instrumentation change.🤖 Generated with Claude Code