chore: bump CommonLibVR submodule by alandtse · Pull Request #109 · alandtse/open-shaders

alandtse · 2026-06-06T06:08:46Z

Bumps extern/CommonLibSSE-NG (= alandtse/CommonLibVR) from 8f4205da5 to 6b48ca992 on ng:

feat: add water parallax, caustics, and improved cubemaps community-shaders/skyrim-community-shaders#177 MenuEventHandler VR vtable shift — correct VR menu input dispatch across flat/VR/multi-runtime.
Shared PerPass/PerTechnique/PerFrame etc. buffers for all CS features community-shaders/skyrim-community-shaders#178 remove phantom ISGraphicsTextureFilterMode IS effect (VR index 111 collided with ISReflectionBlurHCS).

Includes the required source adaptation: ShaderCache.cpp dropped the ISGraphicsTextureFilterMode name→index entry (the enum value was removed in community-shaders#178; the entry was a no-op phantom anyway).

Verified locally: full ALL preset configures + builds clean (CommunityShaders.dll produced) against the bumped submodule. Pairs with the FrameAnnotations vr100 fix (#108).

Summary by CodeRabbit

Bug Fixes
- Prevented problematic image-space shader compilation by removing a shader descriptor, avoiding related runtime shader loading/compilation errors.
Chores
- Updated an external library reference to the latest tracked revision.

coderabbitai · 2026-06-06T06:08:57Z

Need the big picture first? Review this PR in Change Stack to see what changed before going file by file.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4e85f659-272f-40c0-85bd-e5abda2c2251

📥 Commits

Reviewing files that changed from the base of the PR and between b9e6742 and 7813357.

📒 Files selected for processing (1)

src/ShaderCache.cpp

📝 Walkthrough

Walkthrough

Advance the extern/CommonLibSSE-NG submodule SHA and remove the BSImagespaceShaderGraphicsTextureFilterMode entry from the imagespace shader descriptor lookup, so that name will no longer resolve and related compile/cache paths will be skipped.

Changes

Dependency Update

Layer / File(s)	Summary
CommonLibSSE-NG submodule reference update `extern/CommonLibSSE-NG`	The submodule reference is advanced from commit `8f4205d...` to commit `6b48ca9...`.

Shader descriptor change

Layer / File(s)	Summary
Remove imagespace shader mapping `src/ShaderCache.cpp`	Deleted the `BSImagespaceShaderGraphicsTextureFilterMode` mapping from the imagespace shader descriptor lookup table; `GetImagespaceShaderDescriptor` will no longer return a descriptor for that shader name and subsequent compile/cache steps will be skipped.

🎯 3 (Moderate) | ⏱️ ~20 minutes

"I’m a rabbit in the code-tree glade,
I nudge a submodule and a shader’s shade.
A tiny change, a hop, a lore —
SHA moved forward, one name’s no more.
🐇✨"

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'chore: bump CommonLibVR submodule' is directly related to the main changeset, which updates the CommonLibSSE-NG submodule. However, the title does not convey the critical change: the removal of ISGraphicsTextureFilterMode from ShaderCache.cpp due to VR enum index collision, which is the substantive code adaptation required by this PR.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch chore/bump-commonlibvr

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 OpenGrep (1.22.0)

OpenGrep fatal error (exit code 2): [00.13][ERROR]: Error: exception Unix_error: No such file or directory stat src/ShaderCache.cpp
Raised by primitive operation at UTmp.replace_named_pipe_by_regular_file_if_needed in file "libs/commons/UTmp.ml", line 145, characters 8-27
Called from Scan_CLI.replace_target_roots_by_regular_files_where_needed.(fun) in file "src/osemgrep/cli_scan/Scan_CLI.ml", lines 1086-1087, characters 19-65
Called from List_.fast_map in file "libs/commons/List_.ml", line 81, characters 17-20
Called from Scan_CLI

🔧 Infer (1.2.0)

src/ShaderCache.cpp

Usage Error: Failed to execute compilation command:
'/opt/infer-linux-x86_64-v1.2.0/lib/infer/infer/bin/../../facebook-clang-plugins/clang/install/bin/clang++'
-c src/ShaderCache.cpp -o /tmp/coderabbit-infer/92be02027aad5586/file.o

Error message:
clang++: error: no such file or directory: 'src/ShaderCache.cpp'

*** Infer needs a working compilation command to run.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

🧹 Nitpick comments (1)

extern/CommonLibSSE-NG (1)
1-1: ⚡ Quick win

Consider adding an explicit issue reference to the PR description.

The PR description mentions pairing with #108 (FrameAnnotations vr100 fix). Consider adding an explicit GitHub keyword to create a linkage:
Related to `#108`
This helps track coordinated changes across PRs.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@extern/CommonLibSSE-NG` at line 1, Update the PR description to include an
explicit issue/PR linkage by adding the GitHub keyword line "Related to `#108`"
(or similar) so the PR is automatically associated with the FrameAnnotations
vr100 fix; edit the PR description field and insert that exact text near the top
or in a "Related issues" section to create the cross-reference.
Source: Coding guidelines

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@extern/CommonLibSSE-NG`:
- Line 1: Update the PR description to include an explicit issue/PR linkage by
adding the GitHub keyword line "Related to `#108`" (or similar) so the PR is
automatically associated with the FrameAnnotations vr100 fix; edit the PR
description field and insert that exact text near the top or in a "Related
issues" section to create the cross-reference.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 779c09d0-7da7-4380-85dc-85165cdabbe2

📥 Commits

Reviewing files that changed from the base of the PR and between 4c873cc and e4e8b15.

📒 Files selected for processing (1)

extern/CommonLibSSE-NG

Copilot

Pull request overview

Updates the extern/CommonLibSSE-NG submodule pointer (alandtse/CommonLibVR on ng) to a newer commit, pulling in upstream fixes relevant to Skyrim VR runtime behavior (VR menu input vtable slot alignment and removal of a colliding/phantom ImageSpaceEffect index).

Changes:

Fast-forward bump of extern/CommonLibSSE-NG from 8f4205da5 → 6b48ca992.
Incorporates upstream fixes described in the PR body (MenuEventHandler VR vtable shift; remove phantom ISGraphicsTextureFilterMode effect index collision).

github-actions · 2026-06-06T06:22:23Z

No actionable suggestions for changed features.

github-actions · 2026-06-06T07:12:04Z

✅ A pre-release build is available for this PR:
Download

Pulls in CommonLibVR ng fixes (8f4205da5 -> 6b48ca992): - community-shaders#177 MenuEventHandler VR vtable shift — correct VR menu input dispatch (ProcessThumbstick/MouseMove/Button) in all build modes - community-shaders#178 remove phantom ISGraphicsTextureFilterMode IS effect (VR index 111) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Required by the CommonLibVR bump: ISGraphicsTextureFilterMode was a phantom IS effect (VR index 111 is actually ISReflectionBlurHCS) and was removed from the enum in CommonLibVR community-shaders#178, so the ShaderCache name->index entry no longer compiles. The entry was a no-op anyway (the shader name doesn't exist). Verified: full ALL preset build succeeds against the bumped submodule. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Copilot AI review requested due to automatic review settings June 6, 2026 06:08

Copilot started reviewing on behalf of alandtse June 6, 2026 06:08 View session

coderabbitai Bot reviewed Jun 6, 2026

View reviewed changes

Copilot AI reviewed Jun 6, 2026

View reviewed changes

alandtse and others added 2 commits June 6, 2026 07:34

Copilot AI review requested due to automatic review settings June 6, 2026 07:34

alandtse force-pushed the chore/bump-commonlibvr branch from bade233 to b9e6742 Compare June 6, 2026 07:34

Copilot started reviewing on behalf of alandtse June 6, 2026 07:35 View session

Copilot AI reviewed Jun 6, 2026

View reviewed changes

Comment thread src/ShaderCache.cpp Outdated

Copilot started work on behalf of alandtse June 6, 2026 09:30 View session

style: simplify ShaderCache omission note

7813357

Copilot finished work on behalf of alandtse June 6, 2026 09:32

alandtse merged commit 6267214 into dev Jun 6, 2026
19 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: bump CommonLibVR submodule#109

chore: bump CommonLibVR submodule#109
alandtse merged 3 commits into
devfrom
chore/bump-commonlibvr

alandtse commented Jun 6, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 6, 2026 •

edited

Loading

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions Bot commented Jun 6, 2026

Uh oh!

github-actions Bot commented Jun 6, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

alandtse commented Jun 6, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

github-actions Bot commented Jun 6, 2026

Uh oh!

github-actions Bot commented Jun 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

alandtse commented Jun 6, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 6, 2026 •

edited

Loading

github-actions Bot commented Jun 6, 2026 •

edited

Loading