Skip to content

fix(FrameAnnotations): correct vr100 depth-buffer label#108

Merged
alandtse merged 1 commit into
devfrom
fix/frameannotations-vr100-depthbuffer
Jun 6, 2026
Merged

fix(FrameAnnotations): correct vr100 depth-buffer label#108
alandtse merged 1 commit into
devfrom
fix/frameannotations-vr100-depthbuffer

Conversation

@alandtse

@alandtse alandtse commented Jun 6, 2026

Copy link
Copy Markdown
Owner

The VR-only DepthBuffer4xDownscale pass (VR ImageSpaceEffect index 100) was annotated with the enum ISCopyDepthBuffer_DR (index 99) — a copy-paste duplicate, so its Render/Dispatch perf events showed the wrong (duplicate) name in captures.

VR index 100 is ISCopyDepthBufferTargetSize, verified against the engine effect-init dispatcher (SkyrimVR.exe ImageSpaceManager init → register helper, index in EDX). Fixed both the Render (vfunc 0x1) and Dispatch (vfunc 0xC) hooks for VTABLE_BSImagespaceShaderDepthBuffer4xDownscale.

Audited all 278 enum/VTABLE annotation pairs — no other mismatches (ISCopyGrayScale/GreyScale is the same shader, gray/grey spelling).

…fferTargetSize

The VR-only DepthBuffer4xDownscale pass (VR ImageSpaceEffect index 100) was
annotated with the enum ISCopyDepthBuffer_DR (index 99) — a copy-paste duplicate,
so its Render/Dispatch perf events showed the wrong (duplicate) name.

VR index 100 is ISCopyDepthBufferTargetSize, verified against the engine
effect-init dispatcher (SkyrimVR.exe ImageSpaceManager init register helper,
EDX=index). Fixed both the Render (vfunc 0x1) and Dispatch (vfunc 0xC) hooks for
VTABLE_BSImagespaceShaderDepthBuffer4xDownscale. Audited all 278 enum/VTABLE
annotation pairs; no other mismatches.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings June 6, 2026 05:53
@coderabbitai

coderabbitai Bot commented Jun 6, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@alandtse, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 5 minutes and 20 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 97ad5e3d-8943-4769-ab02-b893e6dee618

📥 Commits

Reviewing files that changed from the base of the PR and between 4c873cc and b35a364.

📒 Files selected for processing (1)
  • src/FrameAnnotations.cpp
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/frameannotations-vr100-depthbuffer

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 6, 2026

Copy link
Copy Markdown

No actionable suggestions for changed features.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes an incorrect frame-annotation label for a VR-only image-space depth pass so GPU/CPU perf capture event names correctly reflect the underlying ImageSpaceEffect index.

Changes:

  • Corrects the BSImagespaceShaderDepthBuffer4xDownscale Render hook annotation from ISCopyDepthBuffer_DR to ISCopyDepthBufferTargetSize.
  • Corrects the BSImagespaceShaderDepthBuffer4xDownscale Dispatch hook annotation from ISCopyDepthBuffer_DR to ISCopyDepthBufferTargetSize.

@alandtse alandtse changed the title fix(FrameAnnotations): label vr100 depth-buffer pass as ISCopyDepthBufferTargetSize fix(FrameAnnotations): correct vr100 depth-buffer label Jun 6, 2026
@github-actions

github-actions Bot commented Jun 6, 2026

Copy link
Copy Markdown

✅ A pre-release build is available for this PR:
Download

@alandtse alandtse merged commit 62832b2 into dev Jun 6, 2026
22 checks passed
@alandtse alandtse deleted the fix/frameannotations-vr100-depthbuffer branch June 6, 2026 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants