fix(FrameAnnotations): correct vr100 depth-buffer label#108
Conversation
…fferTargetSize The VR-only DepthBuffer4xDownscale pass (VR ImageSpaceEffect index 100) was annotated with the enum ISCopyDepthBuffer_DR (index 99) — a copy-paste duplicate, so its Render/Dispatch perf events showed the wrong (duplicate) name. VR index 100 is ISCopyDepthBufferTargetSize, verified against the engine effect-init dispatcher (SkyrimVR.exe ImageSpaceManager init register helper, EDX=index). Fixed both the Render (vfunc 0x1) and Dispatch (vfunc 0xC) hooks for VTABLE_BSImagespaceShaderDepthBuffer4xDownscale. Audited all 278 enum/VTABLE annotation pairs; no other mismatches. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 5 minutes and 20 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
No actionable suggestions for changed features. |
There was a problem hiding this comment.
Pull request overview
Fixes an incorrect frame-annotation label for a VR-only image-space depth pass so GPU/CPU perf capture event names correctly reflect the underlying ImageSpaceEffect index.
Changes:
- Corrects the
BSImagespaceShaderDepthBuffer4xDownscaleRender hook annotation fromISCopyDepthBuffer_DRtoISCopyDepthBufferTargetSize. - Corrects the
BSImagespaceShaderDepthBuffer4xDownscaleDispatch hook annotation fromISCopyDepthBuffer_DRtoISCopyDepthBufferTargetSize.
|
✅ A pre-release build is available for this PR: |
The VR-only
DepthBuffer4xDownscalepass (VRImageSpaceEffectindex 100) was annotated with the enumISCopyDepthBuffer_DR(index 99) — a copy-paste duplicate, so its Render/Dispatch perf events showed the wrong (duplicate) name in captures.VR index 100 is
ISCopyDepthBufferTargetSize, verified against the engine effect-init dispatcher (SkyrimVR.exeImageSpaceManagerinit → register helper, index in EDX). Fixed both the Render (vfunc0x1) and Dispatch (vfunc0xC) hooks forVTABLE_BSImagespaceShaderDepthBuffer4xDownscale.Audited all 278 enum/VTABLE annotation pairs — no other mismatches (
ISCopyGrayScale/GreyScaleis the same shader, gray/grey spelling).