Skip to content

Conversation

@radka-j
Copy link
Member

@radka-j radka-j commented Apr 30, 2025

One of the cells in the workflow notebook takes too long to run so it gets interrupted during the build, meaning the rest of the notebook doesn't render. I am trying to set up the docs so that the workflow notebook doesn't execute on each build (and instead the pre-rendered content should be displayed). The updates here I based on suggestions from ChatGPT (which has gotten it wrong before). Any suggestions for better ways to go about this welcome!

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@radka-j radka-j changed the title Workflow notebook fixes Update docs to not execute workflow notebook Apr 30, 2025
@radka-j radka-j requested a review from sgreenbury April 30, 2025 09:57
@github-actions
Copy link
Contributor

github-actions bot commented Apr 30, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  tests
  test_compare.py
Project Total  

This report was generated by python-coverage-comment-action

@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.00%. Comparing base (a751d9a) to head (c296451).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #446      +/-   ##
==========================================
- Coverage   80.03%   80.00%   -0.03%     
==========================================
  Files         100      100              
  Lines        6903     6903              
==========================================
- Hits         5525     5523       -2     
- Misses       1378     1380       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sgreenbury
Copy link
Collaborator

Now updated to not execute notebook and include outputs in notebooks + fix the repeated displays in dashboard. Merging now with additional changes #450.

@sgreenbury sgreenbury merged commit 240dadd into main Apr 30, 2025
@sgreenbury sgreenbury deleted the add_tutorial_to_docs branch April 30, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants