-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: incorrectly worded error message in argocd-update is corrected #3192
Conversation
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Rohan <[email protected]>
@RohanMishra315, it looks like there's a test case that is sensitive to the wording in that error and needs to be adjusted accordingly:
You can run the tests locally to ensure this passes: https://docs.kargo.io/contributor-guide/hacking-on-kargo#running-tests After that's corrected, LGTM. Thank you for this! |
…est assertions Signed-off-by: Rohan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @RohanMishra315!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3192 +/- ##
=======================================
Coverage 51.40% 51.40%
=======================================
Files 288 288
Lines 26108 26108
=======================================
Hits 13421 13421
Misses 11961 11961
Partials 726 726 ☔ View full report in Codecov by Sentry. |
fixes : #3163
Changed the phrasing from "was not initiated by %q and not by %q" to "was initiated by %q and not by %q".
This directly states who initiated the operation (status.Operation.InitiatedBy.Username) and clarifies it wasn't initiated by the expected user (applicationOperationInitiator).