Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrectly worded error message form argocd-update step causes confusion #3163

Closed
krancour opened this issue Dec 19, 2024 · 1 comment · Fixed by #3192
Closed

incorrectly worded error message form argocd-update step causes confusion #3163

krancour opened this issue Dec 19, 2024 · 1 comment · Fixed by #3192
Assignees
@RohanMishra315
Labels
area/controller good first issue Good issue for a new contributor to handle help-wanted Community help on this would be appreciated kind/bug priority/normal size/tiny Less than 1 hour of work
Milestone
v1.2.0

Comments

@krancour
Copy link
Member

krancour commented Dec 19, 2024 •
edited
Loading 

time="2024-12-19T19:03:00Z" level=info msg="current operation was not initiated by \"kargo-controller\" and not by \"\": waiting for operation to complete" freight=b764d720b186a9d73685a01f7600e8a4b0f03727 namespace=akuity-platform

This was meant to say something like "was initiated by <actual initiator> and not by kargo-controller."

As worded, that's not the meaning it's conveying.
@krancour krancour added kind/bug good first issue Good issue for a new contributor to handle priority/normal area/controller size/tiny Less than 1 hour of work help-wanted Community help on this would be appreciated labels Dec 19, 2024
@RohanMishra315
Copy link
Contributor

Hey @krancour should I look into it ?

@RohanMishra315 RohanMishra315 mentioned this issue Dec 24, 2024
Merged
@krancour krancour added this to the v1.2.0 milestone Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RohanMishra315 RohanMishra315

Labels
area/controller good first issue Good issue for a new contributor to handle help-wanted Community help on this would be appreciated kind/bug priority/normal size/tiny Less than 1 hour of work
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging a pull request may close this issue.

fix: incorrectly worded error message in argocd-update is corrected RohanMishra315/kargo
2 participants
@krancour @RohanMishra315