fix: incorrectly worded error message in argocd-update is corrected #3192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Rohan <[email protected]>
RohanMishra315
changed the title
|
@RohanMishra315, it looks like there's a test case that is sensitive to the wording in that error and needs to be adjusted accordingly: You can run the tests locally to ensure this passes: https://docs.kargo.io/contributor-guide/hacking-on-kargo#running-tests After that's corrected, LGTM. Thank you for this! |
…est assertions Signed-off-by: Rohan <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3192 +/- ##
=======================================
Coverage 51.40% 51.40%
=======================================
Files 288 288
Lines 26108 26108
=======================================
Hits 13421 13421
Misses 11961 11961
Partials 726 726 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes : #3163
Changed the phrasing from "was not initiated by %q and not by %q" to "was initiated by %q and not by %q".
This directly states who initiated the operation (status.Operation.InitiatedBy.Username) and clarifies it wasn't initiated by the expected user (applicationOperationInitiator).