Applying suggestions from Julian#3
Merged
aks- merged 2 commits intorefactor-with-nanocomponentfrom Jan 22, 2018
unknown repository
Merged
Applying suggestions from Julian#3aks- merged 2 commits intorefactor-with-nanocomponentfrom unknown repository
aks- merged 2 commits intorefactor-with-nanocomponentfrom
unknown repository
Conversation
Owner
|
@martinheidegger you broke the tests, can you please fix them? I won't be able to make time right now |
Author
|
see: https://github.com/aks-/dat-desktop/pull/2#issuecomment-359041057
|
Owner
|
@martinheidegger it was working before those 2 commits, so probably something to do with them. I believe it's ac85705 |
Owner
|
@martinheidegger it was issue with deps, fixed it. Thanks for making changes to the PR :) You are probably sleeping right now, good night :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applying suggestions from @juliangruber in dat-ecosystem-archive#450