Fixing several problems with the nanocomponent PR#2
Fixing several problems with the nanocomponent PR#2martinheidegger wants to merge 12 commits intorefactor-with-nanocomponentfrom unknown repository
Conversation
…e some problems in debugging and seems like a violation of control flow; so I extracted the logic into a functional method.
…rings don’t occur so frequently by using .render instead of .createElement
|
@martinheidegger looks good... you have lint errors, can you please run the test suite.
Additionally for some reason it doesn't show name and hexicon on first dat, and still the hexicon is not changing on mouseover P.S. Thanks for PR :) I will hopefully get some time tomorrow to take a look at it |
|
Ah, thank you for point out those errors, I knew i forgot to do something 😅 |
|
I wasnt able to reproduce your display problem, but I did find some way to improve the hover logic. The tests are broken but I can't quite understand how (they fail with behavior that I can experience in regular user mode). It would be awesome to get some help tracking them down. (Also I think I should add more tests but its 3am here right now, and family weekend is waiting) |
aks-
force-pushed
the
refactor-with-nanocomponent
branch
from
1b01530 to
56229d3
Compare
|
@martinheidegger fixed and merged |
2 participants
Trying to figure out what didn't work with the nanocomponent PR i stumbled over a few issues. I attempted to explain each fix in each commit.