Backport #8430 and #8441 to v1.5: AutoDilate metadata + double-dilate fix - #8443
Closed
Aaronontheweb wants to merge 2 commits into
Closed
Aaronontheweb wants to merge 2 commits into
Aaronontheweb wants to merge 2 commits into
Conversation
…ol>, ...) This overload resolved its bound as RemainingOrDilated(RemainingOrDilated(timeout)), applying akka.test.timefactor twice. Every sibling overload applies it once. With timefactor = 3 an explicit 5s wait became 45s. The null case is worse: the inner call resolves to RemainingOrDefault - the time actually left in the enclosing Within - and the outer call then dilates that, producing a bound larger than the remaining budget it was derived from. Apply RemainingOrDilated once, matching every other overload. No in-repo caller uses this overload, so nothing here was relying on the inflated bound; Akka.TestKit.Tests (320) and Akka.TestKit.Xunit2.Tests (4) pass.
…data + double-dilate fix
Member
Author
|
Superseded by #8466 (backport/v1.5.71) — this PR's API approval files were stale; the new PR includes the AutoDilate approval updates and passes all net10.0 approval tests locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8430 and #8441 to
v1.5.ExpectMsgAsync<T>(Func<T, IActorRef, bool>, ...)[AutoDilate]metadata to TestKit timeout parameters