Skip to content

Add AutoDilate metadata to TestKit timeout parameters - #8441

Merged
Aaronontheweb merged 2 commits into
akkadotnet:devfrom
Aaronontheweb:feature/8440-testkit-auto-dilate-metadata
Jul 30, 2026
Merged

Aaronontheweb merged 2 commits into
akkadotnet:devfrom
Aaronontheweb:feature/8440-testkit-auto-dilate-metadata

Conversation

@Aaronontheweb

Copy link
Copy Markdown
Member

Fixes #8440

Related to akkadotnet/akka.analyzers#148.

Summary

  • add public parameter-level AutoDilateAttribute metadata to Akka.TestKit
  • annotate caller-supplied durations that TestKit always scales, including EventFilter and cluster TestKit wrappers
  • leave raw, interval, idle, epsilon, and conditionally dilated durations unannotated
  • correct AwaitConditionNoThrow documentation to match its raw timeout behavior
  • add reflection-based positive and negative metadata contract tests and update API approvals

The Akka.Remote.TestKit audit found no additional caller-supplied duration parameters that automatically apply the TestKit time factor.

Validation

  • dotnet build src/core/Akka.TestKit/Akka.TestKit.csproj -c Release
  • dotnet build src/core/Akka.Cluster.TestKit/Akka.Cluster.TestKit.csproj -c Release
  • dotnet build src/core/Akka.Remote.TestKit/Akka.Remote.TestKit.csproj -c Release
  • dotnet test src/core/Akka.TestKit.Tests/Akka.TestKit.Tests.csproj -c Release (324 passed, 1 skipped)
  • dotnet test src/core/Akka.Remote.TestKit.Tests/Akka.Remote.TestKit.Tests.csproj -c Release (15 passed, 2 skipped)
  • dotnet test src/core/Akka.Cluster.Tests.MultiNode/Akka.Cluster.Tests.MultiNode.csproj -c Release --filter FullyQualifiedName~AutoDilateMetadataSpec (2 passed)
  • dotnet test src/core/Akka.API.Tests/Akka.API.Tests.csproj -c Release --filter FullyQualifiedName=Akka.API.Tests.CoreAPISpec.ApproveTestKit (1 passed)
  • dotnet format verification for the three newly added C# files

@Aaronontheweb Aaronontheweb added akka-testkit Akka.NET Testkit issues api-change labels Jul 30, 2026

@Aaronontheweb Aaronontheweb left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb
Aaronontheweb merged commit 1e12bac into akkadotnet:dev Jul 30, 2026
1 check passed
@Aaronontheweb
Aaronontheweb deleted the feature/8440-testkit-auto-dilate-metadata branch July 30, 2026 20:34
Aaronontheweb added a commit to Aaronontheweb/akka.net that referenced this pull request Jul 31, 2026
Aaronontheweb added a commit to Aaronontheweb/akka.net that referenced this pull request Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

akka-testkit Akka.NET Testkit issues api-change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add AutoDilateAttribute metadata to automatically dilated TestKit parameters

1 participant