Skip to content

[Bug] Fix deprecation of --force in conda for conda versions >= 24.3.0 #1403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HaoZeke merged 1 commit into from
Jun 4, 2024
Merged

[Bug] Fix deprecation of --force in conda for conda versions >= 24.3.0 #1403

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions asv/plugins/conda.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,9 +146,18 @@ def _setup(self):
env_file.close()
try:
env_file_name = self._conda_environment_file or env_file.name
self._run_conda(['env', 'create', '-f', env_file_name,
'-p', self._path, '--force'],

conda_version = self._run_conda(['--version'], env=env)
log.info(f"conda version: {conda_version}")
# https://conda.io/projects/conda/en/latest/release-notes.html#id8
if conda_version >= "24.3.0":
self._run_conda(['env', 'create', '-f', env_file_name,
'-p', self._path, "--yes"],
env=env)
else: # Backward compatbility
self._run_conda(['env', 'create', '-f', env_file_name,
'-p', self._path, '--force'],
env=env)

if self._conda_environment_file and (conda_args or pip_args):
# Add extra packages
Expand Down