Skip to content

[Bug] Fix deprecation of --force in conda for conda versions >= 24.3.0#1403

Merged
HaoZeke merged 1 commit intoairspeed-velocity:mainfrom
h-mayorquin:main
Jun 4, 2024
Merged

[Bug] Fix deprecation of --force in conda for conda versions >= 24.3.0#1403
HaoZeke merged 1 commit intoairspeed-velocity:mainfrom
h-mayorquin:main

Conversation

@h-mayorquin
Copy link
Copy Markdown
Contributor

The option to use --force to create environment was deprecated from conda:

https://conda.io/projects/conda/en/latest/release-notes.html#id8

This patch works for me. Let me know if it needs any additions for this to move forward.

@h-mayorquin
Copy link
Copy Markdown
Contributor Author

h-mayorquin commented May 31, 2024

Ah, I see this is addressed on:
#1397
But without backwards compatbility

Copy link
Copy Markdown
Member

@HaoZeke HaoZeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, could you perhaps add @ivirshup as a co-author on the commit since he had the same fix as well?

@h-mayorquin
Copy link
Copy Markdown
Contributor Author

h-mayorquin commented Jun 3, 2024

@HaoZeke
Added them.

Copy link
Copy Markdown
Member

@HaoZeke HaoZeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @h-mayorquin LGTM, will merge when CI passes... Please use BUG: or MAINT: or ENH: as commit prefixes for any subsequent PRs :)

Co-authored-by: ivirshup <ivirshup@gmail.com>

Closes airspeed-velocitygh-1396
@HaoZeke HaoZeke merged commit 4af8c69 into airspeed-velocity:main Jun 4, 2024
@HaoZeke
Copy link
Copy Markdown
Member

HaoZeke commented Jun 4, 2024

Thanks @h-mayorquin

@HaoZeke HaoZeke mentioned this pull request Jun 4, 2024
@h-mayorquin
Copy link
Copy Markdown
Contributor Author

@HaoZeke thanks to you for working on this project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants