Skip to content

Upgrade to bval 2.0.0 #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
electrum merged 1 commit into from
Nov 14, 2018
Merged

Upgrade to bval 2.0.0 #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
Airbase 89

* Dependency updates:
- validation-api 2.0.1 (from 1.1.0)
- BVal 2.0.0 (from 1.1.1)

Airbase 88

* Replace dependency-versions-check with Enforcer requireUpperBoundDeps
Expand Down
23 changes: 3 additions & 20 deletions airbase/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,9 @@
<dep.slf4j.version>1.7.25</dep.slf4j.version>
<dep.logback.version>1.2.3</dep.logback.version>
<dep.javax-inject.version>1</dep.javax-inject.version>
<dep.javax-validation.version>1.1.0.Final</dep.javax-validation.version>
<dep.javax-validation.version>2.0.1.Final</dep.javax-validation.version>
Copy link
Copy Markdown
Member

@electrum electrum Nov 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this to CHANGES

<dep.javax-servlet.version>3.1.0</dep.javax-servlet.version>
<dep.bval.version>2.0.0</dep.bval.version>
<dep.jackson.version>2.9.7</dep.jackson.version>
<dep.jmxutils.version>1.19</dep.jmxutils.version>
<dep.cglib.version>3.2.5</dep.cglib.version>
Expand Down Expand Up @@ -1126,28 +1127,10 @@
</dependency>

<!-- misc stuff -->

<!-- bval 1.1.1 depends on commons-lang3 3.3.2, which is incompatible with Java 9 -->
<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-lang3</artifactId>
<version>3.4</version>
</dependency>

<dependency>
Copy link
Copy Markdown
Member

@electrum electrum Nov 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can delete this dependency now. Based on the comment, it was added to force a newer version (than bval used) that is compatible with Java 9.

<groupId>org.apache.bval</groupId>
<artifactId>bval-jsr</artifactId>
<version>1.1.1</version>
<exclusions>
<exclusion>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
</exclusion>
<exclusion>
<groupId>commons-logging</groupId>
<artifactId>commons-logging</artifactId>
</exclusion>
</exclusions>
<version>${dep.bval.version}</version>
</dependency>

<dependency>
Expand Down