Conversation
|
@electrum Validation 2.0 brings ability to validate List and Optional elements, for example |
electrum
left a comment
electrum
left a comment
There was a problem hiding this comment.
I'm thinking we should actually remove BVal from Airbase and just have it in Airlift, since no one needs to use it directly. It's an implementation detail of configuration and ValidationAssertions in testing. Thoughts?
| <dep.logback.version>1.2.3</dep.logback.version> | ||
| <dep.javax-inject.version>1</dep.javax-inject.version> | ||
| <dep.javax-validation.version>1.1.0.Final</dep.javax-validation.version> | ||
| <dep.javax-validation.version>2.0.1.Final</dep.javax-validation.version> |
airbase/pom.xml
Outdated
| <!-- misc stuff --> | ||
|
|
||
| <!-- bval 1.1.1 depends on commons-lang3 3.3.2, which is incompatible with Java 9 --> | ||
| <dependency> |
There was a problem hiding this comment.
We can delete this dependency now. Based on the comment, it was added to force a newer version (than bval used) that is compatible with Java 9.
airbase/pom.xml
Outdated
| <artifactId>bval-jsr</artifactId> | ||
| <version>1.1.1</version> | ||
| <version>${dep.bval.version}</version> | ||
| <exclusions> |
There was a problem hiding this comment.
None of these exclusions should be needed now. I added it to a new project and dependency:tree shows no dependencies. Although it's strange that commons-weaver-privilizer-api is declared as a dependency but Maven doesn't pick it up.
There was a problem hiding this comment.
Ah, I see it's not picked up because the parent POM declares it as provided scope in dependencyManagement. I didn't realize you could do that (and it seems strange).
|
Thinking about this more, since it appears the API didn't change, the only requirement is updating in Airbase (or otherwise bumping the dependency version). We don't need to change Airlift at all. So maybe leaving it in Airbase is better? |
|
There is additional bonus when this stays in airbase -- when i want to do validation outside of airlift |
findepi
force-pushed
the
findepi/master/upgrade-to-bval-2-0-0-79bd30
branch
from
eda6053 to
4b9f3dd
Compare
2 participants
No description provided.