Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destination S3 V2: copy over legacy DATs, enable tests #48490

Draft
wants to merge 25 commits into
base: jschmidt/s3v2/issue-10732/staging-tests
Choose a base branch
from

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Nov 13, 2024

the only remaining disabled tests are:

the commits, in order:

  • copying over all the DAT tests, associated secrets configuration, enabling V2 tests
  • correcting the image name in all the DAT tests
  • making the V2 tests dump the data using the actual schema, rather than trying to coerce to the expected schema

Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 3:15am

@edgao edgao force-pushed the edgao/enable_all_tests branch 2 times, most recently from 08f8f37 to 880286a Compare November 14, 2024 19:01
@edgao edgao changed the base branch from edgao/bulk_cdk_bigints to master November 14, 2024 19:01
@edgao edgao changed the base branch from master to edgao/bulk_cdk_bigints November 15, 2024 17:55
@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Nov 15, 2024
Base automatically changed from edgao/bulk_cdk_bigints to edgao/alltypes_stringifying November 15, 2024 21:25
@edgao edgao force-pushed the edgao/alltypes_stringifying branch from 8b0f0ed to 2a18eb5 Compare November 15, 2024 21:41
@edgao edgao force-pushed the edgao/enable_all_tests branch 4 times, most recently from 645501b to a8085a8 Compare November 15, 2024 22:53
@edgao edgao force-pushed the edgao/alltypes_stringifying branch from 2a18eb5 to b4ae32f Compare November 15, 2024 22:53
@johnny-schmidt johnny-schmidt force-pushed the edgao/alltypes_stringifying branch 5 times, most recently from 3058730 to a204cff Compare November 18, 2024 17:33
@johnny-schmidt johnny-schmidt force-pushed the edgao/alltypes_stringifying branch 4 times, most recently from 526c3a8 to 0daa8e1 Compare November 19, 2024 17:10
@johnny-schmidt johnny-schmidt force-pushed the edgao/enable_all_tests branch 3 times, most recently from 811aa69 to 2b9754a Compare November 25, 2024 00:19
@johnny-schmidt johnny-schmidt changed the base branch from master to jschmidt/s3v2/issue-10732/staging-tests November 25, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues CDK Connector Development Kit connectors/destination/s3-v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants