Bulk load CDK: test refactors #48488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
octavia-squidington-iii
added
area/connectors
edgao
commented
Nov 15, 2024
| @@ -0,0 +1 @@ | |||
| testExecutionConcurrency=-1 | |||
There was a problem hiding this comment.
I don't understand what changed, but this used to not be necessary https://airbytehq-team.slack.com/archives/C06E6CQMDT3/p1731520778573749
There was a problem hiding this comment.
Did we upgrade gradle?
There was a problem hiding this comment.
🤷 I didn't bother digging into the commit history for this, the workaround is easy enough
edgao
force-pushed
the
edgao/alltypes_stringifying
branch
2 times, most recently
from
2a18eb5
to
b4ae32f
Compare
edgao
commented
Nov 15, 2024
| @@ -19,13 +20,19 @@ import java.math.BigInteger | |||
| import java.nio.ByteBuffer | |||
|
|
|||
| object Jsons : ObjectMapper() { | |||
| // allow jackson to deserialize anything under 100 MiB | |||
| // (the default, at time of writing 2024-05-29, with jackson 2.15.2, is 20 MiB) | |||
| private const val JSON_MAX_LENGTH = 100 * 1024 * 1024 | |||
There was a problem hiding this comment.
this diff is just matching our existing behavior from
(it's also needed to make the float-handling test work)
edgao
commented
Nov 15, 2024
...bulk/toolkits/load-parquet/src/main/kotlin/io/airbyte/cdk/load/file/parquet/ParquetWriter.kt
Show resolved
Hide resolved
...-cdk/bulk/core/load/src/testFixtures/kotlin/io/airbyte/cdk/load/test/util/IntegrationTest.kt
Show resolved
Hide resolved
johnny-schmidt
force-pushed
the
edgao/alltypes_stringifying
branch
2 times, most recently
from
7af7f37
to
ad4a14c
Compare
johnny-schmidt
force-pushed
the
edgao/alltypes_stringifying
branch
3 times, most recently
from
bbe5444
to
2c4d189
Compare
benmoriceau
approved these changes
Nov 18, 2024
|
core/base changes LGTM |
edgao
commented
Nov 18, 2024
johnny-schmidt
force-pushed
the
edgao/alltypes_stringifying
branch
from
3058730
to
a204cff
Compare
johnny-schmidt
force-pushed
the
edgao/alltypes_stringifying
branch
3 times, most recently
from
e6882ff
to
27b6f5e
Compare
johnny-schmidt
force-pushed
the
edgao/alltypes_stringifying
branch
from
27b6f5e
to
e66380f
Compare
johnny-schmidt
force-pushed
the
edgao/alltypes_stringifying
branch
from
526c3a8
to
0daa8e1
Compare
tryangul
pushed a commit
that referenced
this pull request
Nov 21, 2024
Co-authored-by: Johnny Schmidt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just look at the commits individually, they're hopefully organized in a reasonable way.