Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking(Apollo): Update to Apollo v3 and Graphql v15 #415

Merged
merged 1 commit into from
May 13, 2021

Conversation

nilgradisnik
Copy link
Contributor

to: @alecklandgraf

Description

Update Apollo client to v3 and GraphQL v15. Followup from #413

Motivation and Context

Apollo client v3 has been out for quite some time and we want to make sure Lunar is up to date. This release contains quite a few breaking changes so this PR is following the migration guide consolidating packages to @apollo/client and taking care of breaking changes.

This PR also updates GraphQL to v15 making sure we're up to date.

Also migrated to use lodash/fp.

Testing

Updated unit tests. Tested in Storybook.

Screenshots

N/A

Checklist

  • My code follows the style guide of this project.
  • I have updated or added documentation accordingly.
  • I have read the CONTRIBUTING document.

Update Apollo client v3, consolidating packages to @apollo/client and taking care of breaking changes.
Update GraphQL to v15.
Migrate to lodash/fp.
@nilgradisnik nilgradisnik force-pushed the nil--apollo-graphql-update branch from 0d6bf7f to 4b1066e Compare May 12, 2021 23:35
@airbnb-bot
Copy link
Collaborator

Size Changes

Package Diff ESM Prev ESM CJS Prev CJS
apollo +1.1% 10.69 KB 10.58 KB 13.42 KB 13.82 KB

Compared to master. File sizes are unminified and ungzipped.

View raw build stats

Previous (master)

{
  "apollo": {
    "esm": 10832,
    "lib": 14147
  },
  "app-shell": {
    "esm": 12906,
    "lib": 19874
  },
  "composer": {
    "esm": 68247,
    "lib": 101805
  },
  "core": {
    "esm": 584567,
    "lib": 733164
  },
  "forms": {
    "esm": 37350,
    "lib": 49298
  },
  "icons": {
    "esm": 156355,
    "lib": 205626
  },
  "layouts": {
    "esm": 15298,
    "lib": 20770
  },
  "metrics": {
    "esm": 5467,
    "lib": 7729
  },
  "test-utils": {
    "esm": 4279,
    "lib": 5937
  }
}

Current

{
  "apollo": {
    "esm": 10946,
    "lib": 13746
  },
  "app-shell": {
    "esm": 12906,
    "lib": 19874
  },
  "composer": {
    "esm": 68247,
    "lib": 101805
  },
  "core": {
    "esm": 584567,
    "lib": 733164
  },
  "forms": {
    "esm": 37350,
    "lib": 49298
  },
  "icons": {
    "esm": 156355,
    "lib": 205626
  },
  "layouts": {
    "esm": 15298,
    "lib": 20770
  },
  "metrics": {
    "esm": 5467,
    "lib": 7729
  },
  "test-utils": {
    "esm": 4279,
    "lib": 5937
  }
}

@nilgradisnik nilgradisnik merged commit b5788bb into master May 13, 2021
@nilgradisnik nilgradisnik deleted the nil--apollo-graphql-update branch May 13, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants