release(Apollo): Update to Apollo v3 and GraphQL v15 #413
Conversation
nilgradisnik
force-pushed
the
nil--apollo-update
branch
from
87c4f4e to
bcc67ed
Compare
| @@ -36,7 +33,7 @@ export default function addToList<Result, Vars = {}>( | |||
| } | |||
| } | |||
|
|
|||
| set(nextResult, listPath, [...list, data]); | |||
| const nextResult = set(listPath, [...list, data], { ...queryResult }); | |||
There was a problem hiding this comment.
get and set function from lodash/fp have different order of arguments
Size Changes
View raw build statsPrevious (master){
"apollo": {
"esm": 10832,
"lib": 14147
},
"app-shell": {
"esm": 12906,
"lib": 19874
},
"composer": {
"esm": 68247,
"lib": 101805
},
"core": {
"esm": 584567,
"lib": 733164
},
"forms": {
"esm": 37350,
"lib": 49298
},
"icons": {
"esm": 156355,
"lib": 205626
},
"layouts": {
"esm": 15298,
"lib": 20770
},
"metrics": {
"esm": 5467,
"lib": 7729
},
"test-utils": {
"esm": 4279,
"lib": 5937
}
}Current{
"apollo": {
"esm": 10946,
"lib": 13746
},
"app-shell": {
"esm": 12906,
"lib": 19874
},
"composer": {
"esm": 68247,
"lib": 101805
},
"core": {
"esm": 584567,
"lib": 733164
},
"forms": {
"esm": 37350,
"lib": 49298
},
"icons": {
"esm": 156355,
"lib": 205626
},
"layouts": {
"esm": 15298,
"lib": 20770
},
"metrics": {
"esm": 5467,
"lib": 7729
},
"test-utils": {
"esm": 4279,
"lib": 5937
}
} |
|
|
||
| return (cache: DataProxy) => { | ||
| return (cache: ApolloCache<Result>) => { |
There was a problem hiding this comment.
ApolloCache class implements DataProxy interface and we need it to evict cache
| cache.evict({ | ||
| id: cache.identify(resultRoot), | ||
| broadcast: false, | ||
| }); |
There was a problem hiding this comment.
As stated here apollographql/apollo-client#6451 (comment) we need to evict cache when removing items from a list
| nextResult, | ||
| const rootItem = listPath.split('.')[0]; | ||
| // @ts-ignore | ||
| const resultRoot = queryResult[rootItem] as StoreObject; |
There was a problem hiding this comment.
Not sure if there's a better way to identify nested nodes but to evict cache we need at least the top level node ID for the cache.identify call below.
| import prepareQuery from '../utils/prepareQuery'; | ||
| import getQueryName from '../utils/getQueryName'; | ||
|
|
||
| export default function addToList<Result, Vars = {}>( | ||
| docOrQuery: DocumentNode | DataProxy.Query<Vars>, | ||
| docOrQuery: DocumentNode | DataProxy.Query<Vars, Result>, |
There was a problem hiding this comment.
DataProxy.Query requires both variables and result types now
| } | ||
| }." | ||
| `; | ||
| exports[`addToList() errors if query does not exist in cache 1`] = `"\\"otherQuery\\" list \\"something.things\\" is not an array."`; |
There was a problem hiding this comment.
cache.readQuery does not throw an error if there's no results anymore, it returns null instead. That's why the other error is thrown here.
|
Ummm, we should no longer have commits in this repo as it's deprecated and has been merged into pineapple. @alecklandgraf do you disagree? |
|
If you still need to make changes to particular packages, we should maybe move those packages to be internal? |
nilgradisnik
force-pushed
the
nil--apollo-update
branch
from
bcc67ed to
c97b00e
Compare
|
@williaster I think this patch migrates the Apollo client to the version in pineapple. |
This reverts commit ea0d95c.
This reverts commit ea0d95c.
to: @williaster @alecklandgraf
Description
Update Apollo client to v3 and GraphQL v15
Motivation and Context
Apollo client v3 has been out for quite some time and we want to make sure Lunar is up to date. This release contains quite a few breaking changes so this PR is following the migration guide consolidating packages to
@apollo/clientand taking care of breaking changes.This PR also updates GraphQL to v15 making sure we're up to date.
Also migrated to use
lodash/fp.Testing
Updated unit tests. Tested in Storybook.
Screenshots
N/A
Checklist