Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TextEditorCursorStyle.Block for Normal mode. #103

Merged
merged 1 commit into from
Jun 9, 2016
Merged

Use TextEditorCursorStyle.Block for Normal mode. #103

merged 1 commit into from
Jun 9, 2016

Conversation

aminroosta
Copy link
Contributor

This uses Bock cursor style form vscode new api for Normal mode.

I tried to use the same for Vitual Mode, but vscode Ranges are not inclusive and if we use cursor block style the character that is behind the cursor is not selected.

@aminroosta
Copy link
Contributor Author

@aioutecism I've created an issue in vscode repo microsoft/vscode#7413
I think inclusive Ranges are the solution and there is no acceptable workaround without them.

@aioutecism
Copy link
Owner

Nice! Thanks!

@aioutecism aioutecism merged commit a2b699d into aioutecism:master Jun 9, 2016
@shamrin
Copy link
Contributor

shamrin commented Jun 10, 2016

Thank you @aminroosta! Cursor looks great now, with a nice contrast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants